From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 61307@debbugs.gnu.org
Subject: bug#61307: 30.0.50; pixel-scroll-precision-mode: window-scroll-functions?
Date: Tue, 14 Feb 2023 15:06:36 +0200 [thread overview]
Message-ID: <83edqse6qr.fsf@gnu.org> (raw)
In-Reply-To: <873579jaot.fsf@web.de> (message from Michael Heerdegen on Tue, 14 Feb 2023 02:30:10 +0100)
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 61307@debbugs.gnu.org
> Date: Tue, 14 Feb 2023 02:30:10 +0100
>
> > Because you might make scrolling much slower if you call the scroll
> > functions every pixel.
>
> Sorry that I repeat myself, but I don't understand why that would
> happen. This is what I tried:
>
> *** /tmp/ediffnuE8b2 2023-02-14 02:24:24.300444006 +0100
> --- /home/micha/software/emacs/lisp/pixel-scroll.el 2023-02-14 02:20:40.472154353 +0100
> ***************
> *** 725,731 ****
> (beginning-of-buffer
> (message (error-message-string '(beginning-of-buffer))))
> (end-of-buffer
> ! (message (error-message-string '(end-of-buffer))))))))))
> (mwheel-scroll event nil))))
>
> (defun pixel-scroll-kinetic-state (&optional window)
> --- 725,733 ----
> (beginning-of-buffer
> (message (error-message-string '(beginning-of-buffer))))
> (end-of-buffer
> ! (message (error-message-string '(end-of-buffer))))))
> ! (run-hook-with-args 'window-scroll-functions
> ! (selected-window) (window-start))))))
> (mwheel-scroll event nil))))
>
> (defun pixel-scroll-kinetic-state (&optional window)
>
> I don't see the hook called for each pixel. What do you mean?
Each time you do the smallest possible scroll, by how many pixels, or
by what fraction of the screen-line's height does Emacs scroll the
window? IOW, by how many pixels is the display scrolled for each call
to window-scroll-functions?
Precision pixel-scrolling supports many different devices (mice and
touch-pads), which can scroll at very different resolutions. The
possibility that window-scroll-functions be called too frequently
depends on what exactly do your device and your Emacs build support in
this scenario, and I don't yet have a clear idea about that, since you
didn't tell.
> A second thing I wonder about: the docstring of
> `window-scroll-functions' says:
>
> | These functions are called whenever the `window-start' marker is modified,
> | either to point into another buffer (e.g. via `set-window-buffer') or another
> | place in the same buffer.
>
> Is this correct and complete?
More or less. (I don't like how it explains this stuff by using
internal implementation detail, but I cannot think of a better
explanation that is still accurate enough.)
> Is the window-start marker modified in our scenario?
Not in the way that the "usual" scrolling commands do. This mode uses
non-nil 3rd argument to set-window-start. So the display engine
doesn't know that the window is scrolled.
next prev parent reply other threads:[~2023-02-14 13:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 1:49 bug#61307: 30.0.50; pixel-scroll-precision-mode: window-scroll-functions? Michael Heerdegen
2023-02-06 12:15 ` Eli Zaretskii
2023-02-06 21:30 ` Michael Heerdegen
2023-02-12 12:15 ` Eli Zaretskii
2023-02-13 2:20 ` Michael Heerdegen
2023-02-13 3:31 ` Eli Zaretskii
2023-02-13 3:44 ` Michael Heerdegen
2023-02-13 12:56 ` Eli Zaretskii
2023-02-14 1:30 ` Michael Heerdegen
2023-02-14 13:06 ` Eli Zaretskii [this message]
2023-02-15 4:06 ` Michael Heerdegen
2023-02-15 13:21 ` Eli Zaretskii
2023-02-16 4:57 ` Michael Heerdegen
2023-02-16 8:22 ` Eli Zaretskii
2023-02-16 8:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16 8:54 ` Michael Heerdegen
2023-02-19 5:50 ` Michael Heerdegen
2023-02-19 6:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 7:36 ` Michael Heerdegen
2023-02-19 8:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-06 14:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-06 15:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edqse6qr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61307@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).