unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 62713@debbugs.gnu.org, Gregor Zattler <grfz@gmx.de>,
	Tassilo Horn <tsdh@gnu.org>
Subject: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images
Date: Fri, 29 Sep 2023 20:25:09 +0530	[thread overview]
Message-ID: <87ttrddo6q.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkmkRpTqSccWv4BBV7+nLNKKixQT=5zCacwMALe-gKRi3iA@mail.gmail.com> (Stefan Kangas's message of "Fri, 29 Sep 2023 02:43:50 -0700")

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

[வெள்ளி செப்டம்பர் 29, 2023] Stefan Kangas wrote:

> Tassilo Horn <tsdh@gnu.org> writes:
>
>> Stefan Kangas <stefankangas@gmail.com> writes:
>>
>>>> This particular problem can be easily solved by the following simple
>>>> patch instead:
>>>
>>> Tassilo, could you perhaps take a look at this patch?
>>
>> Yes, the simple patch looks good and fixes the bug.  Feel free to commit
>> it.
>
> Great, thanks.
>
> Visuwesh, could you please send the patch as an attachment instead?  We
> prefer that patches are created with a command like `git format-patch
> -1'.

Please find attached patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-doc-view-conversion-indicator-for-svg-images.patch --]
[-- Type: text/x-diff, Size: 994 bytes --]

From a73ab9af07f5867da3b6ff97c73d35230ea21c1e Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Fri, 29 Sep 2023 20:23:56 +0530
Subject: [PATCH] Fix doc-view conversion indicator for svg images

* lisp/doc-view.el (doc-view-pdf->png-converter-mupdf): Show the
corrector pdf->svg indicator when producing svg images.  bug#62713
---
 lisp/doc-view.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index b856b09c8b7..c0d27bdc68a 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -1283,7 +1283,8 @@ doc-view-pdf->png-converter-mupdf
                                     (expand-file-name
                                      doc-view-epub-user-stylesheet)))))))
     (doc-view-start-process
-     "pdf->png" doc-view-pdfdraw-program
+     (concat "pdf->" (symbol-name doc-view--image-type))
+     doc-view-pdfdraw-program
      `(,@(doc-view-pdfdraw-program-subcommand)
        ,@options
        ,pdf
-- 
2.40.1


  reply	other threads:[~2023-09-29 14:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 16:02 bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images Gregor Zattler
2023-09-24 23:31 ` Stefan Kangas
2023-09-25  4:30   ` Visuwesh
2023-09-25  8:20     ` Stefan Kangas
2023-09-25 12:47     ` Visuwesh
2023-09-26 11:43       ` Stefan Kangas
2023-09-29  9:34         ` Tassilo Horn
2023-09-29  9:43           ` Stefan Kangas
2023-09-29 14:55             ` Visuwesh [this message]
2023-10-01 13:00               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttrddo6q.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=62713@debbugs.gnu.org \
    --cc=grfz@gmx.de \
    --cc=stefankangas@gmail.com \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).