From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images Date: Fri, 29 Sep 2023 20:25:09 +0530 Message-ID: <87ttrddo6q.fsf@gmail.com> References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> <87edimmncq.fsf@gmail.com> <87r0mh9v1x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10508"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62713@debbugs.gnu.org, Gregor Zattler , Tassilo Horn To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 29 16:56:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmEum-0002PB-33 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Sep 2023 16:56:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmEuU-000523-EY; Fri, 29 Sep 2023 10:56:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmEuC-0004h3-4t for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 10:55:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmEuB-0005tV-Qr for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 10:55:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmEuQ-0000mc-DP for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2023 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62713 X-GNU-PR-Package: emacs Original-Received: via spool by 62713-submit@debbugs.gnu.org id=B62713.16959993392973 (code B ref 62713); Fri, 29 Sep 2023 14:56:02 +0000 Original-Received: (at 62713) by debbugs.gnu.org; 29 Sep 2023 14:55:39 +0000 Original-Received: from localhost ([127.0.0.1]:56901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmEu3-0000ls-7h for submit@debbugs.gnu.org; Fri, 29 Sep 2023 10:55:39 -0400 Original-Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:57581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmEtz-0000la-8b for 62713@debbugs.gnu.org; Fri, 29 Sep 2023 10:55:37 -0400 Original-Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-690d8c05784so11510187b3a.2 for <62713@debbugs.gnu.org>; Fri, 29 Sep 2023 07:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695999314; x=1696604114; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kJfI9wTSmc7zI9zu+qM++miqTVeK+CIzJT1SVhCPlc4=; b=gG3O60kOkqpG1iyfbfgUh6C5qTReKu5GI75JMwWdnxZOjINyrB1ZsTtFIwup6O3ekl SE1E9748dAkEWxgW2jkT1SK1ZsHarXgTB5ZZrJ/WiH+ycTiSk2+XmUhdNhZdRIzI+02s uSbO1VUlbUZnVZ2dNYQ1JBUaC6Qbk29BlFnYNRPpFh3r81bCscPVqa5W45sD+zbqzqUj vC8ummG8+/zXt6vmOz+jGL+ge+Xts8goQdFuUNMIrhFPCdbRa0PWGU7HYpRyR/7kqlZ2 li+14H5I7OLtitiPalC9EXGzUoEdC5gMO/tIbF/nK9hUSXEtZDWgiN3l9CROkJaq/ksE n4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695999314; x=1696604114; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kJfI9wTSmc7zI9zu+qM++miqTVeK+CIzJT1SVhCPlc4=; b=d+hHqQ6dLG3El1ogYoyA2Oa1djRCYUzEzODMLEMDwiq2aNEB+wRZUQYW9cnipK63X/ rWPacFlaIBiFDDm5joIhkWAlqwV7FcEK/O/D1JSJotYLDdo1n32neoYIZpdKmnEP19lt eDHJXERoBNYTIhVam9TaXqhg03LBa4kJC6q/2sbF7dX4tQBoUuqr65WUf2npSmatFRvV ODBUpMHEi/VhE1OA4e90cZweuKG+qC0XRhtO/Ij1tB5nEA0Fx/dTUGVUxo32VBvgiN+y ZuDUmbAtD3OY34xGOLvE/JdlyzGhMw4J0MgEmMSoKbpCyiYjJOyPGn3knrmlYHS0NtA2 nocw== X-Gm-Message-State: AOJu0YzSfyw+PFVjLw1Bdc+ohEQ5c+rOBEFXLl/CafhDp+ymwRJwYQHw 5CsGi4eTumBTuzCNAaO/pZU= X-Google-Smtp-Source: AGHT+IHPjGXZhaTijqQFj7hImfZQTIJdB31S7Zfxz/3dO3Vu980Yv0JL5GtY/lcJ+SDdGpxkcndcZA== X-Received: by 2002:a05:6a20:5490:b0:161:5ea5:fc0b with SMTP id i16-20020a056a20549000b001615ea5fc0bmr5049218pzk.16.1695999313124; Fri, 29 Sep 2023 07:55:13 -0700 (PDT) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id f25-20020aa782d9000000b00690d1269691sm4199139pfn.22.2023.09.29.07.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 07:55:12 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Fri, 29 Sep 2023 02:43:50 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271494 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=9A=E0=AF=86= =E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 29= , 2023] Stefan Kangas wrote: > Tassilo Horn writes: > >> Stefan Kangas writes: >> >>>> This particular problem can be easily solved by the following simple >>>> patch instead: >>> >>> Tassilo, could you perhaps take a look at this patch? >> >> Yes, the simple patch looks good and fixes the bug. Feel free to commit >> it. > > Great, thanks. > > Visuwesh, could you please send the patch as an attachment instead? We > prefer that patches are created with a command like `git format-patch > -1'. Please find attached patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-doc-view-conversion-indicator-for-svg-images.patch >From a73ab9af07f5867da3b6ff97c73d35230ea21c1e Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Fri, 29 Sep 2023 20:23:56 +0530 Subject: [PATCH] Fix doc-view conversion indicator for svg images * lisp/doc-view.el (doc-view-pdf->png-converter-mupdf): Show the corrector pdf->svg indicator when producing svg images. bug#62713 --- lisp/doc-view.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b856b09c8b7..c0d27bdc68a 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1283,7 +1283,8 @@ doc-view-pdf->png-converter-mupdf (expand-file-name doc-view-epub-user-stylesheet))))))) (doc-view-start-process - "pdf->png" doc-view-pdfdraw-program + (concat "pdf->" (symbol-name doc-view--image-type)) + doc-view-pdfdraw-program `(,@(doc-view-pdfdraw-program-subcommand) ,@options ,pdf -- 2.40.1 --=-=-=--