From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 11378@debbugs.gnu.org
Subject: bug#11378: 24.1.50; Suggestion: Let M-i in isearch cycle `search-invisible'
Date: Tue, 28 May 2013 01:45:12 +0300 [thread overview]
Message-ID: <87sj1811tq.fsf@mail.jurta.org> (raw)
In-Reply-To: <87lijtcx8m.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 12 Jun 2012 02:44:17 +0300")
>> Anyway I intend to rewrite the filter `isearch-filter-visible' to just
>> check if the text is visible. The code that opens overlays should be
>> moved to the main search loop to work independently from the filter.
>
> I believe the following patch implements the correct interaction of
> filter predicates with search-invisible.
I installed this patch. Now it's possible to implement
two separate features:
1. `isearch-toggle-invisible'. While testing the initial approach
that toggles the value of `search-invisible', I noticed one problem:
after toggling invisibility in one search, it is unexpectedly
reused later in another search.
This is not like `M-s c' (isearch-toggle-case-fold) works
where toggling the value of `isearch-case-fold-search'
affects only the current search. But a new search is
always started with the default value of the user option
`case-fold-search'.
I think a new command `isearch-toggle-invisible' (`M-s i')
should not change the default value of the user option
`search-invisible' defined with `defcustom'.
It should be changed only via Customization UI.
I'll submit a new patch soon that adds a new variable
`isearch-search-invisible' (or maybe just `isearch-invisible')
to toggle its value without changing the value of the user option
`search-invisible'.
2. A patch that implements new search filters
`isearch-filter-text', `isearch-filter-nontext',
`isearch-filter-strings', `isearch-filter-comments'
will be posted to a separate feature request.
next prev parent reply other threads:[~2013-05-27 22:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 6:10 bug#11378: 24.1.50; Suggestion: Let M-i in isearch cycle `search-invisible' Michael Heerdegen
2012-04-29 14:46 ` Stefan Monnier
2012-04-29 15:32 ` Drew Adams
2012-04-29 21:04 ` Lennart Borgman
2012-04-30 0:28 ` Juri Linkov
2012-05-01 9:15 ` Juri Linkov
2012-05-01 12:59 ` Stefan Monnier
2012-05-01 15:15 ` Juri Linkov
2012-05-01 13:14 ` Drew Adams
2012-05-29 16:40 ` Juri Linkov
2012-05-29 18:22 ` Stefan Monnier
2012-05-30 0:40 ` Juri Linkov
2012-05-30 4:32 ` Stefan Monnier
2012-05-31 0:55 ` Juri Linkov
2012-05-31 21:25 ` Stefan Monnier
2018-04-24 19:50 ` Juri Linkov
2019-11-01 18:54 ` Stefan Kangas
2019-11-02 11:01 ` Michael Heerdegen
2012-06-11 23:44 ` Juri Linkov
2013-02-15 9:22 ` Juri Linkov
2013-05-27 22:45 ` Juri Linkov [this message]
2013-05-28 21:47 ` Juri Linkov
2013-05-28 22:45 ` Drew Adams
2013-05-29 22:45 ` Juri Linkov
2013-05-30 3:16 ` Drew Adams
2013-05-30 8:12 ` Juri Linkov
2013-05-30 13:34 ` Drew Adams
2013-05-30 23:47 ` Juri Linkov
2013-06-02 9:47 ` Juri Linkov
2019-11-01 18:50 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj1811tq.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=11378@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).