From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#11378: 24.1.50; Suggestion: Let M-i in isearch cycle `search-invisible' Date: Tue, 28 May 2013 01:45:12 +0300 Organization: JURTA Message-ID: <87sj1811tq.fsf@mail.jurta.org> References: <87haw32hly.fsf@web.de> <87397m6oxf.fsf@mail.jurta.org> <87y5pcdzxx.fsf@mail.jurta.org> <874nqzgcuk.fsf@mail.jurta.org> <87vcjesccy.fsf@mail.jurta.org> <87lijtcx8m.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1369694822 24586 80.91.229.3 (27 May 2013 22:47:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 May 2013 22:47:02 +0000 (UTC) Cc: 11378@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 28 00:47:01 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uh6Bw-0006C2-7d for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 May 2013 00:47:00 +0200 Original-Received: from localhost ([::1]:39723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh6Bv-0004Si-Tz for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 May 2013 18:46:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh6Bp-0004RY-BG for bug-gnu-emacs@gnu.org; Mon, 27 May 2013 18:46:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uh6Bk-0001CX-C7 for bug-gnu-emacs@gnu.org; Mon, 27 May 2013 18:46:53 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh6Bk-0001CT-8X for bug-gnu-emacs@gnu.org; Mon, 27 May 2013 18:46:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Uh6Cw-0003Ph-FG for bug-gnu-emacs@gnu.org; Mon, 27 May 2013 18:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2013 22:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11378-submit@debbugs.gnu.org id=B11378.136969483213039 (code B ref 11378); Mon, 27 May 2013 22:48:02 +0000 Original-Received: (at 11378) by debbugs.gnu.org; 27 May 2013 22:47:12 +0000 Original-Received: from localhost ([127.0.0.1]:36886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uh6C8-0003OF-85 for submit@debbugs.gnu.org; Mon, 27 May 2013 18:47:12 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:57495 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uh6C3-0003O1-4j for 11378@debbugs.gnu.org; Mon, 27 May 2013 18:47:09 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A5C27258B9E91C; Mon, 27 May 2013 15:45:50 -0700 (PDT) In-Reply-To: <87lijtcx8m.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 12 Jun 2012 02:44:17 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74605 Archived-At: >> Anyway I intend to rewrite the filter `isearch-filter-visible' to just >> check if the text is visible. The code that opens overlays should be >> moved to the main search loop to work independently from the filter. > > I believe the following patch implements the correct interaction of > filter predicates with search-invisible. I installed this patch. Now it's possible to implement two separate features: 1. `isearch-toggle-invisible'. While testing the initial approach that toggles the value of `search-invisible', I noticed one problem: after toggling invisibility in one search, it is unexpectedly reused later in another search. This is not like `M-s c' (isearch-toggle-case-fold) works where toggling the value of `isearch-case-fold-search' affects only the current search. But a new search is always started with the default value of the user option `case-fold-search'. I think a new command `isearch-toggle-invisible' (`M-s i') should not change the default value of the user option `search-invisible' defined with `defcustom'. It should be changed only via Customization UI. I'll submit a new patch soon that adds a new variable `isearch-search-invisible' (or maybe just `isearch-invisible') to toggle its value without changing the value of the user option `search-invisible'. 2. A patch that implements new search filters `isearch-filter-text', `isearch-filter-nontext', `isearch-filter-strings', `isearch-filter-comments' will be posted to a separate feature request.