* bug#25585: Fwd: [reddit] 1 new message from u/hvis
[not found] <20170201155249.114487.66089.C90F097C@redditmail.com>
@ 2017-02-01 23:31 ` Bob Hepple
2020-08-19 11:49 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Bob Hepple @ 2017-02-01 23:31 UTC (permalink / raw)
To: 25585
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
This patch (suggested by https://reddit.com/u/hvis) works for me ...
diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index a0bbf55..dc296a2 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -483,6 +483,7 @@ sh-mode-syntax-table
?~ "_"
?, "_"
?= "."
+ ?/ "."
?\; "."
?| "."
?& "."
[-- Attachment #2: Type: text/html, Size: 1792 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#25585: Fwd: [reddit] 1 new message from u/hvis
2017-02-01 23:31 ` bug#25585: Fwd: [reddit] 1 new message from u/hvis Bob Hepple
@ 2020-08-19 11:49 ` Lars Ingebrigtsen
2020-08-19 12:00 ` Dmitry Gutov
2020-10-02 5:12 ` Lars Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-19 11:49 UTC (permalink / raw)
To: Bob Hepple; +Cc: 25585
Bob Hepple <bob.hepple@gmail.com> writes:
> This patch (suggested by https://reddit.com/u/hvis) works for me ...
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
>
> index a0bbf55..dc296a2 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -483,6 +483,7 @@ sh-mode-syntax-table
> ?~ "_"
> ?, "_"
> ?= "."
> + ?/ "."
> ?\; "."
> ?| "."
> ?& "."
I've respun the patch below...
So this would change the / character into a punctuation character in
shell buffers? It fixes the reported problem, and it does seem
reasonable to have / classified like that.
Does anybody object to applying this patch? There may be unwanted side
effects...
diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5a47594878..8cd3aad268 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -386,6 +386,7 @@ sh-mode-syntax-table
?~ "_"
?, "_"
?= "."
+ ?/ "."
?\; "."
?| "."
?& "."
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#25585: Fwd: [reddit] 1 new message from u/hvis
2020-08-19 11:49 ` Lars Ingebrigtsen
@ 2020-08-19 12:00 ` Dmitry Gutov
2020-08-19 12:07 ` Lars Ingebrigtsen
2020-10-02 5:12 ` Lars Ingebrigtsen
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2020-08-19 12:00 UTC (permalink / raw)
To: Lars Ingebrigtsen, Bob Hepple; +Cc: 25585
On 19.08.2020 14:49, Lars Ingebrigtsen wrote:
> Does anybody object to applying this patch? There may be unwanted side
> effects...
I object to the use of tab character for indentation in a newly added
line. ;-)
That patch was from me, BTW.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#25585: Fwd: [reddit] 1 new message from u/hvis
2020-08-19 12:00 ` Dmitry Gutov
@ 2020-08-19 12:07 ` Lars Ingebrigtsen
2020-08-19 12:11 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-19 12:07 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Bob Hepple, 25585
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 19.08.2020 14:49, Lars Ingebrigtsen wrote:
>> Does anybody object to applying this patch? There may be unwanted side
>> effects...
>
> I object to the use of tab character for indentation in a newly added
> line. ;-)
And I worked to hard on "fixing" the patch to match the surrounding
lines! :-)
> That patch was from me, BTW.
Oh, sorry. Didn't follow the link.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#25585: Fwd: [reddit] 1 new message from u/hvis
2020-08-19 12:07 ` Lars Ingebrigtsen
@ 2020-08-19 12:11 ` Dmitry Gutov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Gutov @ 2020-08-19 12:11 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Bob Hepple, 25585
On 19.08.2020 15:07, Lars Ingebrigtsen wrote:
> And I worked to hard on "fixing" the patch to match the surrounding
> lines!:-)
We either hope the indentation converges on one style over the years, or
keep islands of consistent styling (which will break at the edges
anyway). Can't have both.
> Oh, sorry. Didn't follow the link.
It was under a pseudonym anyway.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#25585: Fwd: [reddit] 1 new message from u/hvis
2020-08-19 11:49 ` Lars Ingebrigtsen
2020-08-19 12:00 ` Dmitry Gutov
@ 2020-10-02 5:12 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-02 5:12 UTC (permalink / raw)
To: Bob Hepple; +Cc: 25585
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Does anybody object to applying this patch? There may be unwanted side
> effects...
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
> index 5a47594878..8cd3aad268 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -386,6 +386,7 @@ sh-mode-syntax-table
> ?~ "_"
> ?, "_"
> ?= "."
> + ?/ "."
> ?\; "."
> ?| "."
> ?& "."
No objections (except the indentation), so I went ahead and pushed this
to Emacs 28. If there are regressions, we'll have to revert.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-02 5:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170201155249.114487.66089.C90F097C@redditmail.com>
2017-02-01 23:31 ` bug#25585: Fwd: [reddit] 1 new message from u/hvis Bob Hepple
2020-08-19 11:49 ` Lars Ingebrigtsen
2020-08-19 12:00 ` Dmitry Gutov
2020-08-19 12:07 ` Lars Ingebrigtsen
2020-08-19 12:11 ` Dmitry Gutov
2020-10-02 5:12 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).