* bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
@ 2020-11-15 23:46 João Távora
2020-11-16 0:45 ` João Távora
2021-01-27 3:39 ` Lars Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: João Távora @ 2020-11-15 23:46 UTC (permalink / raw)
To: 44671; +Cc: david
Hi,
Some time ago, I made these two files into GNU ELPA "core" packages, and
I chose Emacs 26.3 as the minimum required version. That was rather
arbitrary and I should have selected Emacs 26.1 instead.
This is because these packages are required by Eglot, which for now, is
specified to work in Emacs 26.1.
Recently an Eglot user complained that he could no longer run Eglot in
that Emacs version, stating that Emacs 26.1 is the version of Emacs
distributed with Debian stable.
So, I've (briefly) tested these two files in Emacs 26.1 and things seem
to work, so I propose the simple change in the patch after my sig. If
no-one opposes, I'll push in few days or so.
João
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index a395453491..82eb6f6976 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1,8 +1,8 @@
;;; project.el --- Operations on the current project -*- lexical-binding: t; -*-
;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
-;; Version: 0.5.2
-;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
+;; Version: 0.5.3
+;; Package-Requires: ((emacs "26.1") (xref "1.0.2"))
;; This is a GNU ELPA :core package. Avoid using functionality that
;; not compatible with the version of Emacs recorded above.
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index e1dd6e56bb..0fd1770cc1 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1,8 +1,8 @@
;;; xref.el --- Cross-referencing commands -*-lexical-binding:t-*-
;; Copyright (C) 2014-2020 Free Software Foundation, Inc.
-;; Version: 1.0.3
-;; Package-Requires: ((emacs "26.3"))
+;; Version: 1.0.4
+;; Package-Requires: ((emacs "26.1"))
;; This is a GNU ELPA :core package. Avoid functionality that is not
;; compatible with the version of Emacs recorded above.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
2020-11-15 23:46 bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages João Távora
@ 2020-11-16 0:45 ` João Távora
2021-01-27 3:39 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: João Távora @ 2020-11-16 0:45 UTC (permalink / raw)
To: 44671; +Cc: david
[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]
Forgot to include the link to the original bug report
https://github.com/joaotavora/eglot/issues/562
João
On Sun, Nov 15, 2020 at 11:47 PM João Távora <joaotavora@gmail.com> wrote:
> Hi,
>
> Some time ago, I made these two files into GNU ELPA "core" packages, and
> I chose Emacs 26.3 as the minimum required version. That was rather
> arbitrary and I should have selected Emacs 26.1 instead.
>
> This is because these packages are required by Eglot, which for now, is
> specified to work in Emacs 26.1.
>
> Recently an Eglot user complained that he could no longer run Eglot in
> that Emacs version, stating that Emacs 26.1 is the version of Emacs
> distributed with Debian stable.
>
> So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> to work, so I propose the simple change in the patch after my sig. If
> no-one opposes, I'll push in few days or so.
>
> João
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index a395453491..82eb6f6976 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1,8 +1,8 @@
> ;;; project.el --- Operations on the current project -*-
> lexical-binding: t; -*-
>
> ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
> -;; Version: 0.5.2
> -;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
> +;; Version: 0.5.3
> +;; Package-Requires: ((emacs "26.1") (xref "1.0.2"))
>
> ;; This is a GNU ELPA :core package. Avoid using functionality that
> ;; not compatible with the version of Emacs recorded above.
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index e1dd6e56bb..0fd1770cc1 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -1,8 +1,8 @@
> ;;; xref.el --- Cross-referencing commands
> -*-lexical-binding:t-*-
>
> ;; Copyright (C) 2014-2020 Free Software Foundation, Inc.
> -;; Version: 1.0.3
> -;; Package-Requires: ((emacs "26.3"))
> +;; Version: 1.0.4
> +;; Package-Requires: ((emacs "26.1"))
>
> ;; This is a GNU ELPA :core package. Avoid functionality that is not
> ;; compatible with the version of Emacs recorded above.
>
>
>
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 2863 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
2020-11-15 23:46 bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages João Távora
2020-11-16 0:45 ` João Távora
@ 2021-01-27 3:39 ` Lars Ingebrigtsen
2021-01-27 10:09 ` João Távora
1 sibling, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-27 3:39 UTC (permalink / raw)
To: João Távora; +Cc: 44671, david
João Távora <joaotavora@gmail.com> writes:
> So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> to work, so I propose the simple change in the patch after my sig. If
> no-one opposes, I'll push in few days or so.
This was apparently never pushed? Did you decide against it?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
2021-01-27 3:39 ` Lars Ingebrigtsen
@ 2021-01-27 10:09 ` João Távora
2021-01-27 18:14 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: João Távora @ 2021-01-27 10:09 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 44671, david
No, I just forgot about it. I have a lot on my plate right now, do
you mind if I ask you to push it?
Thanks,
João
On Wed, Jan 27, 2021 at 3:39 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> > So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> > to work, so I propose the simple change in the patch after my sig. If
> > no-one opposes, I'll push in few days or so.
>
> This was apparently never pushed? Did you decide against it?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
--
João Távora
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
2021-01-27 10:09 ` João Távora
@ 2021-01-27 18:14 ` Dmitry Gutov
2021-01-28 3:18 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-01-27 18:14 UTC (permalink / raw)
To: João Távora, Lars Ingebrigtsen; +Cc: 44671, david
On 27.01.2021 12:09, João Távora wrote:
> No, I just forgot about it. I have a lot on my plate right now, do
> you mind if I ask you to push it?
Please feel free to change the dependency line, but don't bump the xref
version yet.
There are some changes there currently I'm not entirely confident in, to
put them into a release.
For project.el both are okay.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
2021-01-27 18:14 ` Dmitry Gutov
@ 2021-01-28 3:18 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-28 3:18 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 44671, david, João Távora
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 27.01.2021 12:09, João Távora wrote:
>> No, I just forgot about it. I have a lot on my plate right now, do
>> you mind if I ask you to push it?
>
> Please feel free to change the dependency line, but don't bump the
> xref version yet.
>
> There are some changes there currently I'm not entirely confident in,
> to put them into a release.
>
> For project.el both are okay.
OK; I've now pushed the dependency lines in both, but only bumped the
version in project.el.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-28 3:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-15 23:46 bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages João Távora
2020-11-16 0:45 ` João Távora
2021-01-27 3:39 ` Lars Ingebrigtsen
2021-01-27 10:09 ` João Távora
2021-01-27 18:14 ` Dmitry Gutov
2021-01-28 3:18 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).