bug#46397: 27.1; Cannot delete buffer pointing to a file in a path that includes a file

[Matt Armstrong <matt@rfc20.org>]

Bill Wohler <wohler@newt.com> writes:

> Matt Armstrong <matt@rfc20.org> wrote:
>
>> Mike Kupfer <mkupfer@alum.berkeley.edu> writes:
>> 
>> > I'm not sure I completely understanding the logic behind those calls to
>> > unlock-buffer, but I'll take a stab at it.
>> 
>> [...]
>> 
>> Thanks for those analysis Mike.  They make sense to me.
>
> This code was likely originally written in the 80s and well before my
> time in any case, and it isn't code that I've worked with. I concur with
> Mike's analysis as well, and thank him for diving in.

Yes, it looked like old code to me as well.  I suspect that the explicit
`unlock-buffer' call could be eliminated by rewriting this code with the
primitives Emacs provides now.  E.g. a call to `(set-buffer-modified-p
nil)' would call `unlock-buffer' implicitly, if necessary, and might
more clearly convey the problem the original author was trying to solve.

In any case, I don't intend to pursue this further.


> Since I'm reading this out of context, I don't understand it :-). I
> think that if an MH-E user, including me, got the prompt that Mike
> suggested, she would be pretty confused. If the issue at hand arises, it
> would be preferable to speak in the MH-E user's language, such as: Error
> recycling draft buffer, discard or keep? [keep].

The currently proposed solution is to demote file level errors from
`unlock-error' to warnings.  I suspect that Emacs had no standard way to
display warnings in the 80s either!