From: Lars Ingebrigtsen <larsi@gnus.org>
To: Simon McFarlane <sm@desu.ne.jp>
Cc: 47652@debbugs.gnu.org
Subject: bug#47652: 28.0.50; completion-at-point fails in verilog-mode
Date: Mon, 12 Apr 2021 11:46:40 +0200 [thread overview]
Message-ID: <87sg3vygvz.fsf@gnus.org> (raw)
In-Reply-To: <83fd198e-503e-8f47-2bf7-1eb8ca549c49@desu.ne.jp> (Simon McFarlane's message of "Thu, 8 Apr 2021 21:04:15 -0700")
Simon McFarlane <sm@desu.ne.jp> writes:
> After a very pleasant evening with Edebug (seriously, debugging Emacs
> is such a smooth experience) I found what I believe to be the culprit
> and have attached a patch that fixes the issue for me. This is my
> first time contributing to Emacs so I apologize if I've violated the
> mailing list convention or etiquette.
It's a perfect bug report. :-)
> Happy to make adjustments if my patch isn't quite right.
[...]
> - (verilog-func-completion 'module)
> + (save-excursion (verilog-func-completion 'module))
I used your general idea here, but I moved the save-excursion into the
function instead of wrapping the call sites in Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-04-12 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 4:13 bug#47652: 28.0.50; completion-at-point fails in verilog-mode Simon McFarlane
2021-04-09 4:04 ` Simon McFarlane
2021-04-12 9:46 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg3vygvz.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=47652@debbugs.gnu.org \
--cc=sm@desu.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).