From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47652: 28.0.50; completion-at-point fails in verilog-mode Date: Mon, 12 Apr 2021 11:46:40 +0200 Message-ID: <87sg3vygvz.fsf@gnus.org> References: <49a4dea5-5707-03e3-acd2-5737a46c96ec@desu.ne.jp> <83fd198e-503e-8f47-2bf7-1eb8ca549c49@desu.ne.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29583"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47652@debbugs.gnu.org To: Simon McFarlane Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 12 11:48:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVtAx-0007ak-2s for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 11:48:11 +0200 Original-Received: from localhost ([::1]:52328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVtAw-0003dT-4O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 05:48:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVtAo-0003ci-BK for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 05:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVtAo-0007DE-4B for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 05:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVtAo-0005km-2b for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 05:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Apr 2021 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47652 X-GNU-PR-Package: emacs Original-Received: via spool by 47652-submit@debbugs.gnu.org id=B47652.161822082320586 (code B ref 47652); Mon, 12 Apr 2021 09:48:02 +0000 Original-Received: (at 47652) by debbugs.gnu.org; 12 Apr 2021 09:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:56538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVt9q-0005Lj-LL for submit@debbugs.gnu.org; Mon, 12 Apr 2021 05:47:02 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVt9o-0005F0-KP for 47652@debbugs.gnu.org; Mon, 12 Apr 2021 05:47:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=l53Whiu7jmPOSg64q+RolBUcQE815IlLoHChcVw07r4=; b=KmamFCd6EMNch2L7/xHNavUEIl emPv2DsNF0XCRTCo9eKOZXxTivfgH+Dlv2Gkcm6MbDTEkllvTpSLEEUrxaqBQp1AhTFm6aQsigDTC CTKD7BSiCe3sL6RgmL+BikmEd65kSszfHivXk9W3w3F9h7Y3xqrFIpG9Q74JwiCKkEBg=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVt9V-0005vD-FD; Mon, 12 Apr 2021 11:46:53 +0200 X-Now-Playing: Marianne Faithfull's _A Child's Adventure_: "Ashes In My Hand" In-Reply-To: <83fd198e-503e-8f47-2bf7-1eb8ca549c49@desu.ne.jp> (Simon McFarlane's message of "Thu, 8 Apr 2021 21:04:15 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203886 Archived-At: Simon McFarlane writes: > After a very pleasant evening with Edebug (seriously, debugging Emacs > is such a smooth experience) I found what I believe to be the culprit > and have attached a patch that fixes the issue for me. This is my > first time contributing to Emacs so I apologize if I've violated the > mailing list convention or etiquette. It's a perfect bug report. :-) > Happy to make adjustments if my patch isn't quite right. [...] > - (verilog-func-completion 'module) > + (save-excursion (verilog-func-completion 'module)) I used your general idea here, but I moved the save-excursion into the function instead of wrapping the call sites in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no