* bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off
@ 2022-01-22 3:42 Arthur Miller
2022-01-22 11:55 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Arthur Miller @ 2022-01-22 3:42 UTC (permalink / raw)
To: 53436
1. Create an empty org file
2. Add some text and mark as italic, bold etc. For example:
test
/test/
*test*
/*test*/
*/test/*
3. Toggle "pretty entities" on: M-x org-toggle-pretty-entities
Text should be now displayed in italics and bold. Composition of both
does not work (reported as a bug a year or so previously).
4. Toggle "pretty entities" off: M-x org-toggle-pretty-entities
Text should now be displayed as plain text, however that does not
happen, it is still rendered in italics and bold.
I see in the implementation of org-toggle-pretty-entities that it calls
decompose-region, which does not seem to do anything when called from
M-: either. I don't know if it's bug in org-mode or Emacs itself.
In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.17.4)
of 2022-01-18 built on pascal
Repository revision: 9f25c41ad45eaa34c8b7aa88a8c75d5dd4bd7ba7
Repository branch: custom
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Arch Linux
Configured using:
'configure --with-native-compilation --without-compress-install
'CFLAGS=-O2 -march=native -mtune=native -B/usr/bin/mold''
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM GTK3 ZLIB
Important settings:
value of $LANG: sv_SE.UTF-8
locale-coding-system: utf-8-unix
Major mode: Org
Minor modes in effect:
text-scale-mode: t
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug sendmail face-remap org-element avl-tree
generator ol-eww eww xdg url-queue thingatpt mm-url ol-rmail ol-mhe
ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt cl-extra help-mode
speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime
dig gnus-sum shr pixel-fill kinsoku svg dom browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs url-vars gnus-group gnus-undo gnus-start gnus-dbus dbus
xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time
gnus-spec gnus-int gnus-range message mailcap yank-media rmc puny rfc822
mml mml-sec password-cache epa derived epg rfc6068 epg-config mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util
text-property-search mail-utils range mm-util mail-prsvr wid-edit
ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs
ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref
ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint
org-pcomplete pcomplete comint ansi-color ring org-list org-faces
org-entities noutline outline easy-mmode org-version ob-emacs-lisp
ob-core ob-eval org-table oc-basic json map bibtex iso8601 time-date ol
rx org-keys oc seq gv subr-x byte-opt bytecomp byte-compile cconv
org-compat advice org-macs org-loaddefs format-spec find-func cal-menu
calendar cal-loaddefs cl-loaddefs cl-lib iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice
button loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process
native-compile emacs)
Memory information:
((conses 16 232588 20008)
(symbols 48 19534 4)
(strings 32 69756 1699)
(string-bytes 1 2322560)
(vectors 16 37176)
(vector-slots 8 651185 42508)
(floats 8 322 99)
(intervals 56 462 0)
(buffers 992 13))
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off
2022-01-22 3:42 bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off Arthur Miller
@ 2022-01-22 11:55 ` Lars Ingebrigtsen
2022-01-22 21:04 ` Arthur Miller
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-22 11:55 UTC (permalink / raw)
To: Arthur Miller; +Cc: 53436
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Arthur Miller <arthur.miller@live.com> writes:
> 1. Create an empty org file
> 2. Add some text and mark as italic, bold etc. For example:
>
> test
> /test/
> *test*
> /*test*/
> */test/*
>
> 3. Toggle "pretty entities" on: M-x org-toggle-pretty-entities
>
> Text should be now displayed in italics and bold.
I tried to reproduce this, but I see absolutely no differences in the
buffer before or after doing M-x org-toggle-pretty-entities. Are there
some additional steps needed? Do you see any difference when starting
from "emacs -Q"?
[-- Attachment #2: Type: image/png, Size: 25135 bytes --]
[-- Attachment #3: Type: text/plain, Size: 496 bytes --]
This is what it looks like for me, both before and after.
> I see in the implementation of org-toggle-pretty-entities that it calls
> decompose-region, which does not seem to do anything when called from
> M-: either. I don't know if it's bug in org-mode or Emacs itself.
That's... an odd thing to do. I mean, using `decompose-region'. I'm
not even sure what it's supposed to do. Eli?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off
2022-01-22 11:55 ` Lars Ingebrigtsen
@ 2022-01-22 21:04 ` Arthur Miller
2022-01-23 12:27 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Arthur Miller @ 2022-01-22 21:04 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 53436
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Arthur Miller <arthur.miller@live.com> writes:
>
>> 1. Create an empty org file
>> 2. Add some text and mark as italic, bold etc. For example:
>>
>> test
>> /test/
>> *test*
>> /*test*/
>> */test/*
>>
>> 3. Toggle "pretty entities" on: M-x org-toggle-pretty-entities
>>
>> Text should be now displayed in italics and bold.
>
> I tried to reproduce this, but I see absolutely no differences in the
> buffer before or after doing M-x org-toggle-pretty-entities.
Yes, and it should be. My brain was elswhere when I wrote that bug repport. It
is not org-toggle-pretty-entities that control emphasis, it is a variable:
'org-fontify-emphaiszed-test'.
When set to nil it text should not be rendered in italiccs, bold etc, but it
still is. It is still a bug. Manual says that setting this variable to nil will
turn fontification for marked up text:
https://orgmode.org/manual/Emphasis-and-Monospace.html
I appologize for the confusion, I don't know what was with me, why I looked at
org-togge-pretty-entities at all.
> from "emacs -Q"?
Yes of course, I did it in emacs -Q both in repport and now.
>> I see in the implementation of org-toggle-pretty-entities that it calls
>> decompose-region, which does not seem to do anything when called from
>> M-: either. I don't know if it's bug in org-mode or Emacs itself.
>
> That's... an odd thing to do. I mean, using `decompose-region'. I'm
> not even sure what it's supposed to do. Eli?
Forgett about decompose regions, I was looking at wrong spot as described above.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off
2022-01-22 21:04 ` Arthur Miller
@ 2022-01-23 12:27 ` Lars Ingebrigtsen
2022-01-23 14:15 ` Arthur Miller
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-23 12:27 UTC (permalink / raw)
To: Arthur Miller; +Cc: 53436
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
Arthur Miller <arthur.miller@live.com> writes:
> Yes, and it should be. My brain was elswhere when I wrote that bug repport. It
> is not org-toggle-pretty-entities that control emphasis, it is a variable:
>
> 'org-fontify-emphaiszed-test'.
It's spelled org-fontify-emphasized-text -- perhaps that's the problem?
> When set to nil it text should not be rendered in italiccs, bold etc, but it
> still is. It is still a bug. Manual says that setting this variable to nil will
> turn fontification for marked up text:
>
> https://orgmode.org/manual/Emphasis-and-Monospace.html
>
> I appologize for the confusion, I don't know what was with me, why I looked at
> org-togge-pretty-entities at all.
>
>> from "emacs -Q"?
>
> Yes of course, I did it in emacs -Q both in repport and now.
I tried:
emacs -Q
(setq org-fontify-emphasized-text nil)
C-x C-f a.org RET
and got:
[-- Attachment #2: Type: image/png, Size: 21072 bytes --]
[-- Attachment #3: Type: text/plain, Size: 145 bytes --]
So it seems to work as expected for me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off
2022-01-23 12:27 ` Lars Ingebrigtsen
@ 2022-01-23 14:15 ` Arthur Miller
2022-01-24 9:09 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Arthur Miller @ 2022-01-23 14:15 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 53436
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Arthur Miller <arthur.miller@live.com> writes:
>
>> Yes, and it should be. My brain was elswhere when I wrote that bug repport. It
>> is not org-toggle-pretty-entities that control emphasis, it is a variable:
>>
>> 'org-fontify-emphaiszed-test'.
>
> It's spelled org-fontify-emphasized-text -- perhaps that's the problem?
:-) No, I was just typed to write here, in M-: I use completion, and Emacs would
complain about void symbol.
>> When set to nil it text should not be rendered in italiccs, bold etc, but it
>> still is. It is still a bug. Manual says that setting this variable to nil will
>> turn fontification for marked up text:
>>
>> https://orgmode.org/manual/Emphasis-and-Monospace.html
>>
>> I appologize for the confusion, I don't know what was with me, why I looked at
>> org-togge-pretty-entities at all.
>>
>>> from "emacs -Q"?
>>
>> Yes of course, I did it in emacs -Q both in repport and now.
>
> I tried:
>
> emacs -Q
> (setq org-fontify-emphasized-text nil)
> C-x C-f a.org RET
>
Yes, indeed, I expected it to work in same session, but it requires buffer to be
reverted for the setting to take the effect. I guess it was my expection that
was off here. I misred this:
"To turn off fontification for marked up text, you can set
org-fontify-emphasized-text to nil."
to work as a toggle, but it does not. I tested to call org-restart-font-lock,
but it didn't do anything. The only way seems to be to restart entire org-mode,
either via change to another mode or by reverting the buffer.
But close the bug repport. I guess it is not a bug. Thanks for the help.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off
2022-01-23 14:15 ` Arthur Miller
@ 2022-01-24 9:09 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-24 9:09 UTC (permalink / raw)
To: Arthur Miller; +Cc: 53436
Arthur Miller <arthur.miller@live.com> writes:
> Yes, indeed, I expected it to work in same session, but it requires buffer to be
> reverted for the setting to take the effect. I guess it was my expection that
> was off here. I misred this:
>
> "To turn off fontification for marked up text, you can set
> org-fontify-emphasized-text to nil."
>
> to work as a toggle, but it does not. I tested to call org-restart-font-lock,
> but it didn't do anything. The only way seems to be to restart entire org-mode,
> either via change to another mode or by reverting the buffer.
The doc string of that variable says
---
Non-nil means fontify *bold*, /italic/ and _underlined_ text.
Changing this variable requires a restart of Emacs to take effect.
---
> But close the bug repport. I guess it is not a bug. Thanks for the help.
OK, closing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-24 9:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 3:42 bug#53436: 29.0.50; org-toggle-pretty-entities- does not work when toggled off Arthur Miller
2022-01-22 11:55 ` Lars Ingebrigtsen
2022-01-22 21:04 ` Arthur Miller
2022-01-23 12:27 ` Lars Ingebrigtsen
2022-01-23 14:15 ` Arthur Miller
2022-01-24 9:09 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).