From: Lars Ingebrigtsen <larsi@gnus.org>
To: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Cc: 45999@debbugs.gnu.org
Subject: bug#45999: 28.0.50; repeat does not work when saving files modified outside emacs
Date: Mon, 11 Jul 2022 14:55:47 +0200 [thread overview]
Message-ID: <87sfn7vmek.fsf@gnus.org> (raw)
In-Reply-To: <87v8tcfswv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 07 Jun 2022 16:29:52 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I guess a way to fix this would be to introduce a blocklist (containing
> minibuffer-exit/self-insert-command/etc/etc), but I'm not sure how much
> etc this would be. Or perhaps there's a different way around this.
I tried various approaches, but none seemed to work in a satisfactory
way -- adding a variable to inhibit recording last-repeatable-command
didn't work well, because of how it's set from command_loop_1, and a
blocklist just seemed odd.
But the main problem here is that yes-or-no-p now overwrites
last-repeatable-command with exit-minibuffer, and that's a regression at
least, so I've fixed this specific problem. But I'm still not sure
whether it should be fixed in a more general way, and perhaps a
blocklist is the way to go, anyway... but the reason I didn't do that
is because self-insert-command would have to be on that list for
yes-or-no-p to not override `repeat', and that's a behavioural change.
So I went with the easy fix.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-07-11 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 0:45 bug#45999: 28.0.50; repeat does not work when saving files modified outside emacs Gabriel do Nascimento Ribeiro
2022-06-07 14:29 ` Lars Ingebrigtsen
2022-07-11 12:55 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfn7vmek.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=45999@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).