From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45999: 28.0.50; repeat does not work when saving files modified outside emacs Date: Mon, 11 Jul 2022 14:55:47 +0200 Message-ID: <87sfn7vmek.fsf@gnus.org> References: <87v8tcfswv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5389"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45999@debbugs.gnu.org To: Gabriel do Nascimento Ribeiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 14:56:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAsxf-0001CK-CN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 14:56:27 +0200 Original-Received: from localhost ([::1]:53782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAsxd-0005AY-Ma for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 08:56:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAsxH-0005A4-Cd for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 08:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAsxH-0003UO-3l for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 08:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAsxG-0004zY-Rh for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 08:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45999-submit@debbugs.gnu.org id=B45999.165754416119180 (code B ref 45999); Mon, 11 Jul 2022 12:56:02 +0000 Original-Received: (at 45999) by debbugs.gnu.org; 11 Jul 2022 12:56:01 +0000 Original-Received: from localhost ([127.0.0.1]:38764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAsxE-0004zI-RM for submit@debbugs.gnu.org; Mon, 11 Jul 2022 08:56:01 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAsxC-0004z0-31 for 45999@debbugs.gnu.org; Mon, 11 Jul 2022 08:55:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J4BPQPrHQ2AX+S2nkCC6rysrvU3qeE6HyAAk8ns4dNo=; b=LHuoF9q/m+gbn5hov6MOb73Ozb RfeleNbpBHlhEXuDEfO5c0fZSc1uyutkHbY+7v3dC8cTOpnUMVxD3sx9KarBGlI5p8c6ce/HZiFSj /hP/u+/Arw3a9Ve8gKJTTy85/GqWsF7c4elf7UGSY+pUbA0M9D4NQh4KCx9IAxyw03kQ=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAsx2-00035r-CB; Mon, 11 Jul 2022 14:55:50 +0200 In-Reply-To: <87v8tcfswv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 07 Jun 2022 16:29:52 +0200") X-Now-Playing: Autechre's _Plus_: "ecol4" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236674 Archived-At: Lars Ingebrigtsen writes: > I guess a way to fix this would be to introduce a blocklist (containing > minibuffer-exit/self-insert-command/etc/etc), but I'm not sure how much > etc this would be. Or perhaps there's a different way around this. I tried various approaches, but none seemed to work in a satisfactory way -- adding a variable to inhibit recording last-repeatable-command didn't work well, because of how it's set from command_loop_1, and a blocklist just seemed odd. But the main problem here is that yes-or-no-p now overwrites last-repeatable-command with exit-minibuffer, and that's a regression at least, so I've fixed this specific problem. But I'm still not sure whether it should be fixed in a more general way, and perhaps a blocklist is the way to go, anyway... but the reason I didn't do that is because self-insert-command would have to be on that list for yes-or-no-p to not override `repeat', and that's a behavioural change. So I went with the easy fix. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no