unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#13282: 24.2.91; tramp clobbers file owner/group
@ 2012-12-26 20:17 Andreas Schwab
  2012-12-27 21:28 ` Michael Albinus
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2012-12-26 20:17 UTC (permalink / raw)
  To: 13282

When edititing a file via /sudo:: the owner/group of the file is reset
to root:root.  This is a regression from 24.2.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-26 20:17 bug#13282: 24.2.91; tramp clobbers file owner/group Andreas Schwab
@ 2012-12-27 21:28 ` Michael Albinus
  2012-12-27 22:23   ` Andreas Schwab
  0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2012-12-27 21:28 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: 13282

Andreas Schwab <schwab@linux-m68k.org> writes:

> When edititing a file via /sudo:: the owner/group of the file is reset
> to root:root.  This is a regression from 24.2.

I cannot reproduce it, neither with the emacs-24 branch, nor with the
trunk. Could you, please, check with "emacs -Q"? Do you have special
settings of `backup-by-copying' and friends?

If it still happens to you, please run your test with tramp-verbose set
to 6. And please describe your test case.

> Andreas.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-27 21:28 ` Michael Albinus
@ 2012-12-27 22:23   ` Andreas Schwab
  2012-12-28 16:20     ` Michael Albinus
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2012-12-27 22:23 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 13282

Michael Albinus <michael.albinus@gmx.de> writes:

> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>> When edititing a file via /sudo:: the owner/group of the file is reset
>> to root:root.  This is a regression from 24.2.
>
> I cannot reproduce it, neither with the emacs-24 branch, nor with the
> trunk. Could you, please, check with "emacs -Q"? Do you have special
> settings of `backup-by-copying' and friends?

make-backup-files is nil.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-27 22:23   ` Andreas Schwab
@ 2012-12-28 16:20     ` Michael Albinus
  2012-12-28 16:51       ` Andreas Schwab
  0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2012-12-28 16:20 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: 13282

Andreas Schwab <schwab@linux-m68k.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>
>>> When edititing a file via /sudo:: the owner/group of the file is reset
>>> to root:root.  This is a regression from 24.2.
>>
>> I cannot reproduce it, neither with the emacs-24 branch, nor with the
>> trunk. Could you, please, check with "emacs -Q"? Do you have special
>> settings of `backup-by-copying' and friends?
>
> make-backup-files is nil.

Even with this setting I cannot reproduce. I need the traces, and/or
a simple scenario how to reproduce.

> Andreas.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-28 16:20     ` Michael Albinus
@ 2012-12-28 16:51       ` Andreas Schwab
  2012-12-28 16:54         ` Andreas Schwab
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2012-12-28 16:51 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 13282

Michael Albinus <michael.albinus@gmx.de> writes:

> Even with this setting I cannot reproduce. I need the traces, and/or
> a simple scenario how to reproduce.

It even happens with make-backup-files == t.  Just edit a file with a
non-default group, like /etc/shadow.

Tramp: Inserting `/sudo:root@igel.home:/etc/shadow'...done

Tramp: Checking `vc-registered' for /sudo:root@igel.home:/etc/shadow...done
Tramp: Inserting `/sudo:root@igel.home:/etc/shadow'...done
Saving file /sudo:root@igel.home:/etc/shadow...
Copying /sudo:root@igel.home:/etc/shadow to /sudo:root@igel.home:/etc/shadow.~1~...done
Copying /tmp/tramp.28187Oau to /sudo:root@igel.home:/etc/shadow...done
Wrote /sudo:root@igel.home:/etc/shadow

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-28 16:51       ` Andreas Schwab
@ 2012-12-28 16:54         ` Andreas Schwab
  2012-12-28 17:44           ` Michael Albinus
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2012-12-28 16:54 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 13282

Andreas Schwab <schwab@linux-m68k.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Even with this setting I cannot reproduce. I need the traces, and/or
>> a simple scenario how to reproduce.
>
> It even happens with make-backup-files == t.  Just edit a file with a
> non-default group, like /etc/shadow.
>
> Tramp: Inserting `/sudo:root@igel.home:/etc/shadow'...done
>
> Tramp: Checking `vc-registered' for /sudo:root@igel.home:/etc/shadow...done
> Tramp: Inserting `/sudo:root@igel.home:/etc/shadow'...done
> Saving file /sudo:root@igel.home:/etc/shadow...
> Copying /sudo:root@igel.home:/etc/shadow to /sudo:root@igel.home:/etc/shadow.~1~...done

Note that the backup copy retains the correct attributes.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-28 16:54         ` Andreas Schwab
@ 2012-12-28 17:44           ` Michael Albinus
  2013-01-01  1:47             ` Glenn Morris
  0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2012-12-28 17:44 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: 13282

Andreas Schwab <schwab@linux-m68k.org> writes:

>> It even happens with make-backup-files == t.  Just edit a file with a
>> non-default group, like /etc/shadow.
>>
>> Tramp: Inserting `/sudo:root@igel.home:/etc/shadow'...done
>>
>> Tramp: Checking `vc-registered' for /sudo:root@igel.home:/etc/shadow...done
>> Tramp: Inserting `/sudo:root@igel.home:/etc/shadow'...done
>> Saving file /sudo:root@igel.home:/etc/shadow...
>> Copying /sudo:root@igel.home:/etc/shadow to
>> /sudo:root@igel.home:/etc/shadow.~1~...done
>
> Note that the backup copy retains the correct attributes.

Thanks for this test case; I see it now as well. I've committed a fix to
the emacs-24 branch; could you, please, check?

> Andreas.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13282: 24.2.91; tramp clobbers file owner/group
  2012-12-28 17:44           ` Michael Albinus
@ 2013-01-01  1:47             ` Glenn Morris
  0 siblings, 0 replies; 8+ messages in thread
From: Glenn Morris @ 2013-01-01  1:47 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: 13282

Michael Albinus wrote:

> I've committed a fix to the emacs-24 branch; could you, please, check?

So, did it work for you?





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-01-01  1:47 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-26 20:17 bug#13282: 24.2.91; tramp clobbers file owner/group Andreas Schwab
2012-12-27 21:28 ` Michael Albinus
2012-12-27 22:23   ` Andreas Schwab
2012-12-28 16:20     ` Michael Albinus
2012-12-28 16:51       ` Andreas Schwab
2012-12-28 16:54         ` Andreas Schwab
2012-12-28 17:44           ` Michael Albinus
2013-01-01  1:47             ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).