From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: rajeev.jnk@sivalik.com, 49848@debbugs.gnu.org
Subject: bug#49848: 27.2.50; map-merge plist return alist
Date: Thu, 05 Aug 2021 11:48:41 +0100 [thread overview]
Message-ID: <87r1f8xj3q.fsf@tcd.ie> (raw)
In-Reply-To: <87o8ac38wb.fsf@web.de> (Michael Heerdegen's message of "Thu, 05 Aug 2021 04:47:16 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> In the specific case of merging maps into a desired type, we can simply
>> be more careful in such ambiguous cases. The attached patch does that,
>> while also avoiding the quadratic lookup behaviour for lists.
>
> Looks good and appropriate to me (I could not read very carefully,
> though, I'm tired today and can have a second look tomorrow).
>
> Should we handle the corner case when zero maps get merged?
That's already implied by the &rest args, and checked in
test-map-merge-empty.
>> I think the latter option may facilitate the equal-ity consistency
>> being discussed in https://bug.gnu.org/47368.
>>
>> WDYT?
>
> Seems a good idea to me, too.
Thanks. Unless someone beats me to it or there are further comments,
I'll push the patch to Emacs 28 next week, and probably bump the Version
header too.
--
Basil
next prev parent reply other threads:[~2021-08-05 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 19:38 bug#49848: 27.2.50; map-merge plist return alist Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-03 21:59 ` Michael Heerdegen
2021-08-03 22:45 ` Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-04 0:41 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-04 0:45 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-04 7:47 ` Lars Ingebrigtsen
2021-08-05 2:47 ` Michael Heerdegen
2021-08-05 2:55 ` Michael Heerdegen
2021-08-05 10:48 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-08-14 10:35 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1f8xj3q.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=49848@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=michael_heerdegen@web.de \
--cc=rajeev.jnk@sivalik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).