From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49848: 27.2.50; map-merge plist return alist Date: Thu, 05 Aug 2021 11:48:41 +0100 Message-ID: <87r1f8xj3q.fsf@tcd.ie> References: <87o8ae71yv.fsf@hm.sivalik.com> <877dh2qjf1.fsf@web.de> <877dh282io.fsf@tcd.ie> <87o8ac38wb.fsf@web.de> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rajeev.jnk@sivalik.com, 49848@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 05 12:49:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBaw4-000A9C-4z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Aug 2021 12:49:12 +0200 Original-Received: from localhost ([::1]:39534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBaw3-0004HA-1p for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Aug 2021 06:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBavu-0004FP-QI for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 06:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBavu-0006Lh-JE for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 06:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBavu-0005vq-Ha for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 06:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Aug 2021 10:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49848 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49848-submit@debbugs.gnu.org id=B49848.162816053022784 (code B ref 49848); Thu, 05 Aug 2021 10:49:02 +0000 Original-Received: (at 49848) by debbugs.gnu.org; 5 Aug 2021 10:48:50 +0000 Original-Received: from localhost ([127.0.0.1]:46014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBavi-0005vP-B8 for submit@debbugs.gnu.org; Thu, 05 Aug 2021 06:48:50 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:41884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBavh-0005vB-30 for 49848@debbugs.gnu.org; Thu, 05 Aug 2021 06:48:49 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id c9so5898453wri.8 for <49848@debbugs.gnu.org>; Thu, 05 Aug 2021 03:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yoiKeB3qyiPRuYc360S4ndOh5QaL32F3Z+by9IRlYKg=; b=VLckSIVZt6KurzWMR4mm49/24T6QWQi216LzbWH+BHGw1aSzJus/VnLh1DARGHghnq mD4q3AHo/7Xo/j7O3qYhHqIrFch2p3TKx07cipLpfWve54OuE9Vd5rZx6mvm4FFz8foD pdqJTpZDzNBQx/4xfvYZYhUofkHjtQNylcOS92c794fQ3J4yhg+V103vZo4eev8mC2BR JGBvwJKwzYitT9+fv9oywQglGXCKRdlE2rrNnw7KXvEYoOeMnMZApCKn3FEcB/wA/hvP 0pJtQaGsp0mbW/CTnvlem3aJaUyM/0KPRvM/gRQRHvAFp3bdldtI3x38+G3jjtZ6vhC/ mhWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yoiKeB3qyiPRuYc360S4ndOh5QaL32F3Z+by9IRlYKg=; b=qghBaMbTfLE3ec/2EnUTlc2ieuj9MpG65E1QhfLanHP49agPsRA2y4POcxc9k51S8Z N/og7AkP2qvRMcCWUkrI8EDxRkg8+qLuviBvm++BWyfqh6mPRjfF4P1BRlKtXHQKL3mY pabDr/u/wSKx20a+PyPm8+cc673eadVe/trFZILzylzZ5SxyIqGJo4nwNLxdS7GkEgsZ KT51T1ZnPKgWiU4NAqO6Jr5vlXBjKxwXO3sPs8oESFeFJFyfxyLujveX7aHgqsh7Skd3 2ppG32p/P8HjujjrJlQEseRojl4U9ohXAiRyLgZgSfg2WFvnoxGbrojocdokQFrn5tEM 4deg== X-Gm-Message-State: AOAM531okWJwvin0dEOdsdsfoohdysIeBUYxs0OfaEze/6zmhmNlpdMh kZc+o3kvo0jkuesxS2+5XILsQw== X-Google-Smtp-Source: ABdhPJw8QYgojKPOBDHRCYV7vV3ACwtymQjkAs9+T3R+Xog8SZzC5rZLMT+NPrGxyRx7BosLR74yYA== X-Received: by 2002:a5d:5141:: with SMTP id u1mr4576077wrt.50.1628160522759; Thu, 05 Aug 2021 03:48:42 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id h4sm6031548wru.2.2021.08.05.03.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 03:48:42 -0700 (PDT) In-Reply-To: <87o8ac38wb.fsf@web.de> (Michael Heerdegen's message of "Thu, 05 Aug 2021 04:47:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211215 Archived-At: Michael Heerdegen writes: > "Basil L. Contovounesios" writes: > >> In the specific case of merging maps into a desired type, we can simply >> be more careful in such ambiguous cases. The attached patch does that, >> while also avoiding the quadratic lookup behaviour for lists. > > Looks good and appropriate to me (I could not read very carefully, > though, I'm tired today and can have a second look tomorrow). > > Should we handle the corner case when zero maps get merged? That's already implied by the &rest args, and checked in test-map-merge-empty. >> I think the latter option may facilitate the equal-ity consistency >> being discussed in https://bug.gnu.org/47368. >> >> WDYT? > > Seems a good idea to me, too. Thanks. Unless someone beats me to it or there are further comments, I'll push the patch to Emacs 28 next week, and probably bump the Version header too. -- Basil