From: Lars Ingebrigtsen <larsi@gnus.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: Michael Albinus <michael.albinus@gmx.de>, 54606@debbugs.gnu.org
Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers
Date: Wed, 30 Mar 2022 14:03:26 +0200 [thread overview]
Message-ID: <87r16j8x69.fsf@gnus.org> (raw)
In-Reply-To: <b2b01423d17b33974169d1e6d2193003@webmail.orcon.net.nz> (Phil Sainty's message of "Thu, 31 Mar 2022 00:43:23 +1300")
Phil Sainty <psainty@orcon.net.nz> writes:
> I've just tested with this, and it solves the immediate problem, but
> it's slow. In my test case it's taking ~2s to switch between images,
> whereas it takes only a fraction of a second when I'm ignoring remote
> dired buffers by adding (not (file-remote-p default-directory)) to
> the conditions.
Perhaps the n/p commands should just be changed. It's really unusual to
have several dired buffers open to the same directory, and the dired
buffer we're interested in is usually the one we were in when we started
to view the image.
So perhaps image-mode should just note the dired buffer it's "called
from" (or determine that on startup), and then save that in a
buffer-local variable, and just use that buffer? (Recomputing the
buffer if it's killed.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-30 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 10:13 bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Phil Sainty
2022-03-29 13:03 ` Lars Ingebrigtsen
2022-03-29 13:09 ` Michael Albinus
2022-03-30 11:43 ` Phil Sainty
2022-03-30 11:51 ` Michael Albinus
2022-03-30 12:03 ` Lars Ingebrigtsen [this message]
2022-03-31 9:47 ` Michael Albinus
2022-03-31 11:41 ` Lars Ingebrigtsen
2022-03-31 18:09 ` Phil Sainty
2022-04-01 7:06 ` Michael Albinus
2022-04-02 13:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16j8x69.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=54606@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).