From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Date: Wed, 30 Mar 2022 14:03:26 +0200 Message-ID: <87r16j8x69.fsf@gnus.org> References: <3947f11808243544dcdd4e4d2fde4922@webmail.orcon.net.nz> <87v8vwap2l.fsf@gnus.org> <878rssaos4.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23106"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Michael Albinus , 54606@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 14:04:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZX3a-0005ly-0l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 14:04:10 +0200 Original-Received: from localhost ([::1]:41890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZX3Y-0005s5-VH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 08:04:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZX3S-0005rp-TB for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 08:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZX3S-0000Wc-KO for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 08:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZX3S-0007Mn-Ge for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 08:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 12:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54606 X-GNU-PR-Package: emacs Original-Received: via spool by 54606-submit@debbugs.gnu.org id=B54606.164864182028288 (code B ref 54606); Wed, 30 Mar 2022 12:04:02 +0000 Original-Received: (at 54606) by debbugs.gnu.org; 30 Mar 2022 12:03:40 +0000 Original-Received: from localhost ([127.0.0.1]:34721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZX36-0007MC-6G for submit@debbugs.gnu.org; Wed, 30 Mar 2022 08:03:40 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZX34-0007Lz-6H for 54606@debbugs.gnu.org; Wed, 30 Mar 2022 08:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4LBq3SApmM9tf2KZewTsum7UpLMA8eYc3B4Huym64xQ=; b=e9UCPWm8LYDmvJAgTegmrCYvpl 86T7THaRf6OlwgvZeC44zbMqaYzWNaYeG59SokdtDkUSHmDIX+4vt9ujn3hZVdPhM52FS9PxP2qcB 1JfjraLcp16Kai2Qx4yR3IhfDAxiTa8oX55w9WytKM6v3DTcT3Wdh/90298bIYgY6j3U=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZX2t-0007Xl-Op; Wed, 30 Mar 2022 14:03:30 +0200 In-Reply-To: (Phil Sainty's message of "Thu, 31 Mar 2022 00:43:23 +1300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229101 Archived-At: Phil Sainty writes: > I've just tested with this, and it solves the immediate problem, but > it's slow. In my test case it's taking ~2s to switch between images, > whereas it takes only a fraction of a second when I'm ignoring remote > dired buffers by adding (not (file-remote-p default-directory)) to > the conditions. Perhaps the n/p commands should just be changed. It's really unusual to have several dired buffers open to the same directory, and the dired buffer we're interested in is usually the one we were in when we started to view the image. So perhaps image-mode should just note the dired buffer it's "called from" (or determine that on startup), and then save that in a buffer-local variable, and just use that buffer? (Recomputing the buffer if it's killed.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no