unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Pugnet <simon@polaris64.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 67150@debbugs.gnu.org, contact@sivalik.com
Subject: bug#67150: eglot with typescript language server >= 4.1.0
Date: Wed, 15 Nov 2023 10:27:04 +0000	[thread overview]
Message-ID: <87r0krpayw.fsf@polaris64.net> (raw)
In-Reply-To: <CALDnm51jhk9FrNu70ADwhRBwdO9cR7a=Bh22AJd5JW9Vfz1XoQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]


João Távora <joaotavora@gmail.com> writes:

>> I'm not sure if this fix is correct. In the documentation for
>> `eglot-server-programs' it says: -
>>
>> * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where
>>   MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a
>>   string identifying the language to the server;
>>
>> However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets 
>> the
>> `:language-id' to symbols. So I think these should be strings 
>> instead,
>> e.g. "javascript".
>
> Yup, that was a mistake, guess I should have tested, but I don't
> have this language server.  Keywords would probably work too,
> but I fixed them to strings as you suggest.  Pushed to master
> and cherry-picked to emacs-29.

Perfect, I can confirm that this now works correctly in emacs-29.

Thanks for the quick fix!

Kind regards,

-- 
Simon Pugnet
https://www.polaris64.net/
PGP key fingerprint: 3BF7 85DE 162C 00C8 FB4D  A6FD BA13 59A8 2C0B 
3EF9

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2023-11-15 10:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 11:29 bug#67150: eglot with typescript language server >= 4.1.0 Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 16:37 ` João Távora
2023-11-13 16:42   ` Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 16:49     ` João Távora
2023-11-13 16:57       ` Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-14  0:12         ` João Távora
2023-11-14 12:07           ` Eli Zaretskii
2023-11-14 12:19             ` João Távora
2023-11-14 14:28               ` Eli Zaretskii
2023-11-15  9:51           ` Simon Pugnet
2023-11-15 10:18             ` João Távora
2023-11-15 10:27               ` Simon Pugnet [this message]
2023-11-15 10:29                 ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0krpayw.fsf@polaris64.net \
    --to=simon@polaris64.net \
    --cc=67150@debbugs.gnu.org \
    --cc=contact@sivalik.com \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).