From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simon Pugnet Newsgroups: gmane.emacs.bugs Subject: bug#67150: eglot with typescript language server >= 4.1.0 Date: Wed, 15 Nov 2023 10:27:04 +0000 Message-ID: <87r0krpayw.fsf@polaris64.net> References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> <87o7fvfip4.fsf@polaris64.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21103"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67150@debbugs.gnu.org, contact@sivalik.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 17:28:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3IkO-0005Dr-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 17:28:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3IkJ-0002GD-Cd; Wed, 15 Nov 2023 11:28:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3IkF-0002Fk-TS for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:28:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3IkF-00062t-LR for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:28:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3IkE-00026Q-O6 for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simon Pugnet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67150 X-GNU-PR-Package: emacs Original-Received: via spool by 67150-submit@debbugs.gnu.org id=B67150.17000656758040 (code B ref 67150); Wed, 15 Nov 2023 16:28:02 +0000 Original-Received: (at 67150) by debbugs.gnu.org; 15 Nov 2023 16:27:55 +0000 Original-Received: from localhost ([127.0.0.1]:53107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ik6-00025b-S7 for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:27:55 -0500 Original-Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:39332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ik3-00025C-U4 for 67150@debbugs.gnu.org; Wed, 15 Nov 2023 11:27:53 -0500 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SVfWY5hCPz9sqY; Wed, 15 Nov 2023 11:28:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polaris64.net; s=MBO0001; t=1700044089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlBf5grCy27vU/rt2AvW91HYWlr2Wnk81cw0J/GUosw=; b=rRS1YrLunzOFk2101Dq1Bby/IS50+BDhxTrkYHAFmYFoYRfvvLGAy5Apw812Hw6uXfwpS5 GWfYn4guH+TfbAs90Te6m22kwp3k0lGraOn/iLIaomDwYxIHKl7Ukc+p1mko08L5DwBPQD Sgxh9aKyPNrIGVRAf5T6ivL8c7SFMLxVSEVBdrzbk6obO43cYezDqUKqt+T3BhAvNJ6RDN GbCsNBiKfBpk+iHtyX/7Dc0+noVvrvkRL4yPb1YMM7RykEBMGCs5FAIUBW/1I2CBLDYZSm +1hRUAURhyt/D2Nn3mK26p78i8inednLqcBGLhNA8JQD/vXVlX/yjSx1WQwX1A== In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274371 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora writes: >> I'm not sure if this fix is correct. In the documentation for >> `eglot-server-programs' it says: - >> >> * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where >> MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a >> string identifying the language to the server; >> >> However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets=20 >> the >> `:language-id' to symbols. So I think these should be strings=20 >> instead, >> e.g. "javascript". > > Yup, that was a mistake, guess I should have tested, but I don't > have this language server. Keywords would probably work too, > but I fixed them to strings as you suggest. Pushed to master > and cherry-picked to emacs-29. Perfect, I can confirm that this now works correctly in emacs-29. Thanks for the quick fix! Kind regards, =2D-=20 Simon Pugnet https://www.polaris64.net/ PGP key fingerprint: 3BF7 85DE 162C 00C8 FB4D A6FD BA13 59A8 2C0B=20 3EF9 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCAAyFiEEO/eF3hYsAMj7Tab9uhNZqCwLPvkFAmVUnTcUHHNpbW9uQHBv bGFyaXM2NC5uZXQACgkQuhNZqCwLPvn4mBAAjK0rfqTZcHB2oLUtZn0EerljXC4P RwWr2WPfjsLO9+ZrUe1RMOxPwfswDOCqfZpcPmyFfYjtF8zPCGrVO0Pj97f+Fiac EHdt3YJhymCInIU0lnvhH/UljnyoaLnOPUa1CJYLUuU0AHNMJc1gC4h7tC582zcM rLqmFn4lDXT7lmncGsbH1KxjOmxvQp7ljNijDoh2NmfFIX4NpmI/oPlhSKplmJvn BgsiOjrPABcTHzcTD32+zk+wFNy9mOCji3ah/P9IGzU0kCsISeIsIAY4OQbcwFxv i1SHq3Bf1LGLKNIvHhT5/7R4n27n+5HZb89ujeV/WShP1goGC1wbTxJJP52tXMR+ BNaM2XhVwbSKKqfB0rTIoWqqy8L5MXyUJRpnWZ+vJOtEMAozHgwP+QNiXOYG84sU GBuksoNUZ5tnfylPSxT1iMjfaESfiEDruCdROjKswZeMCgym3mj1Uo6kYqCsCp9L 4AGFUXNpphzbU9VWo5L+Q+EzxfNNhupoFHkNKGZlT/LPQQP13tvbvIRdE7zbbu+O ojZ4DRUX95uwEKbTcU+Ca+LHsd6vDkWimno7RezkbX13ZS1CN91TOEGxxxe4AvP5 9d197MJ6+mZQ/w5MGNB88TiqZC4wViN3V99nEuuBwOOT7WW9hTIzcv8C2HwTVkwq ppJqUUkVkbx3XMs= =W8Lv -----END PGP SIGNATURE----- --=-=-=--