bug#2108: 23.0.60; display of SVG images

bug#2108: 23.0.60; display of SVG images

[Peter Dyballa]

Hello!

When I visit, from dired-mode, /usr/local/share/emacs/23.0.60/etc/ 
images/gnus/gnus.svg and type C-c C-c to see the picture, I see it in  
wrong colours, purple instead of yellow. Other applications show the  
colours correctly. /usr/local/share/emacs/23.0.60/etc/images/icons/ 
hicolor/scalable/apps/emacs.svg appears as a yellow fountain pen  
without logo.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, X toolkit, Xaw3d  
scroll bars)
  of 2009-01-29 on localhost
Windowing system distributor `The XFree86 Project, Inc', version  
11.0.40400000
configured using `configure  '--without-sound' '--without-pop' '-- 
with-dbus' '--with-libotf' '--with-x-toolkit=athena' '--enable- 
locallisppath=/Library/Application Support/Emacs/calendar23:/Library/ 
Application Support/Emacs/caml:/Library/Application Support/Emacs:/sw/ 
share/emacs21/site-lisp/elib' 'PKG_CONFIG_PATH=/sw/lib/xft2/lib/ 
pkgconfig:/sw/lib/fontconfig2/lib/pkgconfig:/sw/lib/freetype219/lib/ 
pkgconfig:/sw/lib/pango-ft219/lib/pkgconfig:/sw/lib/qt4-x11/lib/ 
pkgconfig:/sw/lib/system-openssl/lib/pkgconfig:/sw/lib/pkgconfig:/sw/ 
share/pkgconfig:/usr/X11R6/lib/pkgconfig:/usr/local/lib/pkgconfig:/ 
usr/lib/pkgconfig' 'CFLAGS=-Wno-pointer-sign -H -pipe -fPIC - 
mcpu=7450 -mtune=7450 -fast -mpim-altivec -ftree-vectorize -foptimize- 
register-move -freorder-blocks -freorder-blocks-and-partition - 
fthread-jumps -fpeephole -fno-crossjumping' 'CPPFLAGS=-no-cpp-precomp  
-idirafter -I/usr/X11R6/include' 'LDFLAGS=-dead_strip - 
multiply_defined suppress -L/sw/lib/ncurses''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: de_DE.UTF-8
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: de_DE.UTF-8
   value of $XMODIFIERS: nil
   locale-coding-system: utf-8-unix
   default-enable-multibyte-characters: t

Major mode: XML

Minor modes in effect:
   image-minor-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   global-auto-composition-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t
   view-mode: t


--
Greetings

   Pete

One cannot live by television, video games, top ten CDs, and dumb  
movies alone.
				– Amiri Baraka, 1999

bug#2108: 23.0.60; display of SVG images

[Stephen Berman]

On Thu, 29 Jan 2009 21:43:49 +0100 Peter Dyballa <Peter_Dyballa@Freenet.DE> wrote:

> When I visit, from dired-mode, /usr/local/share/emacs/23.0.60/etc/
> images/gnus/gnus.svg and type C-c C-c to see the picture, I see it in wrong
> colours, purple instead of yellow. Other applications show the  colours
> correctly. /usr/local/share/emacs/23.0.60/etc/images/icons/
> hicolor/scalable/apps/emacs.svg appears as a yellow fountain pen  without
> logo.
>
> In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, X toolkit, Xaw3d scroll
> bars)
>  of 2009-01-29 on localhost


I see this as well in GNU Emacs 23.0.60.31 (i686-pc-linux-gnu, GTK+
Version 2.14.4) of 2009-01-31 on escher.  It is apparently due to this
change:

2009-01-29  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* image.c (svg_load_image): Don't right-shift background RGB when
	obtained from FRAME_BACKGROUND_PIXEL. Under HAVE_NS use ns_query_color.

Reverting image.c to the previous version 1.118 and rebuilding Emacs
restores the correct color of SVG images.

Steve Berman

bug#2108: marked as done (23.0.60; display of SVG images)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]


Your message dated Fri, 06 Feb 2009 12:19:42 -0500
with message-id <87ocxf32kx.fsf@cyd.mit.edu>
and subject line Re: SVG image display is broken
has caused the Emacs bug report #2108,
regarding 23.0.60; display of SVG images
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2108: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2108
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4901 bytes --]

From: Peter Dyballa <Peter_Dyballa@Freenet.DE>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; display of SVG images
Date: Thu, 29 Jan 2009 21:43:49 +0100
Message-ID: <BB62E70D-2753-477E-9D01-BDDC21950A94@Freenet.DE>

Hello!

When I visit, from dired-mode, /usr/local/share/emacs/23.0.60/etc/ 
images/gnus/gnus.svg and type C-c C-c to see the picture, I see it in  
wrong colours, purple instead of yellow. Other applications show the  
colours correctly. /usr/local/share/emacs/23.0.60/etc/images/icons/ 
hicolor/scalable/apps/emacs.svg appears as a yellow fountain pen  
without logo.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, X toolkit, Xaw3d  
scroll bars)
  of 2009-01-29 on localhost
Windowing system distributor `The XFree86 Project, Inc', version  
11.0.40400000
configured using `configure  '--without-sound' '--without-pop' '-- 
with-dbus' '--with-libotf' '--with-x-toolkit=athena' '--enable- 
locallisppath=/Library/Application Support/Emacs/calendar23:/Library/ 
Application Support/Emacs/caml:/Library/Application Support/Emacs:/sw/ 
share/emacs21/site-lisp/elib' 'PKG_CONFIG_PATH=/sw/lib/xft2/lib/ 
pkgconfig:/sw/lib/fontconfig2/lib/pkgconfig:/sw/lib/freetype219/lib/ 
pkgconfig:/sw/lib/pango-ft219/lib/pkgconfig:/sw/lib/qt4-x11/lib/ 
pkgconfig:/sw/lib/system-openssl/lib/pkgconfig:/sw/lib/pkgconfig:/sw/ 
share/pkgconfig:/usr/X11R6/lib/pkgconfig:/usr/local/lib/pkgconfig:/ 
usr/lib/pkgconfig' 'CFLAGS=-Wno-pointer-sign -H -pipe -fPIC - 
mcpu=7450 -mtune=7450 -fast -mpim-altivec -ftree-vectorize -foptimize- 
register-move -freorder-blocks -freorder-blocks-and-partition - 
fthread-jumps -fpeephole -fno-crossjumping' 'CPPFLAGS=-no-cpp-precomp  
-idirafter -I/usr/X11R6/include' 'LDFLAGS=-dead_strip - 
multiply_defined suppress -L/sw/lib/ncurses''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: de_DE.UTF-8
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: de_DE.UTF-8
   value of $XMODIFIERS: nil
   locale-coding-system: utf-8-unix
   default-enable-multibyte-characters: t

Major mode: XML

Minor modes in effect:
   image-minor-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   global-auto-composition-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t
   view-mode: t


--
Greetings

   Pete

One cannot live by television, video games, top ten CDs, and dumb  
movies alone.
				– Amiri Baraka, 1999






[-- Attachment #3: Type: message/rfc822, Size: 1174 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Peter Dyballa <Peter_Dyballa@Freenet.DE>
Cc: Stephen Berman <stephen.berman@gmx.net>, Sven Joachim <svenjoac@gmx.de>, 2108-done@emacsbugs.donarmstrong.com
Subject: Re: SVG image display is broken
Date: Fri, 06 Feb 2009 12:19:42 -0500
Message-ID: <87ocxf32kx.fsf@cyd.mit.edu>

I've checked in a fix for the SVG image bug.  Thanks.