bug#4781: 23.1; sgml-lexical-context on <!-- comments

bug#4781: 23.1; sgml-lexical-context on <!-- comments

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

In a file foo.html containing

    <!-- foo -->

and in html-mode with point on the "foo", calling `sgml-lexical-context'
returns

    (tag . 1)

where I thought from the docstring of that function it would be

    (comment . 1)

I suppose parse-partial-sexp doesn't quite recognise <!--, or not
without the sgml-specials hack.  I get some joy from the lines below.

2009-10-20  Kevin Ryde  <user42@zip.com.au>

	* textmodes/sgml-mode.el (sgml-lexical-context): Recognise
	comment-start-skip to comment-end-skip as `comment' instead of `tag'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sgml-mode.el.lexical-comment.diff --]
[-- Type: text/x-diff, Size: 1049 bytes --]

Index: sgml-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/sgml-mode.el,v
retrieving revision 1.143
diff -u -u -r1.143 sgml-mode.el
--- sgml-mode.el	18 Oct 2009 22:25:40 -0000	1.143
+++ sgml-mode.el	21 Oct 2009 23:02:02 -0000
@@ -1048,6 +1048,12 @@
                   (let ((cdata-start (point)))
                     (unless (search-forward "]]>" pos 'move)
                       (list 0 nil nil 'cdata nil nil nil nil cdata-start))))
+                 ((looking-at comment-start-skip)
+		  ;; parse-partial-sexp doesn't handle <!-- comments -->,
+		  ;; or only if ?- is in sgml-specials, so match explicitly
+                  (let ((start (point)))
+                    (unless (re-search-forward comment-end-skip pos 'move)
+                      (list 0 nil nil nil t nil nil nil start))))
                  ((and sgml-xml-mode (looking-at "<\\?"))
                   ;; Processing Instructions.
                   ;; In SGML, it's basically a normal tag of the form

[-- Attachment #3: Type: text/plain, Size: 1076 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

bug#4781: marked as done (23.1; sgml-lexical-context on <!-- comments)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

Your message dated Sat, 05 Dec 2009 15:23:39 -0500
with message-id <87bpidb25w.fsf@stupidchicken.com>
and subject line Re: 23.1; sgml-lexical-context on <!-- comments
has caused the Emacs bug report #4781,
regarding 23.1; sgml-lexical-context on <!-- comments
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4781: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4781
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5180 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 544 bytes --]

In a file foo.html containing

    <!-- foo -->

and in html-mode with point on the "foo", calling `sgml-lexical-context'
returns

    (tag . 1)

where I thought from the docstring of that function it would be

    (comment . 1)

I suppose parse-partial-sexp doesn't quite recognise <!--, or not
without the sgml-specials hack.  I get some joy from the lines below.

2009-10-20  Kevin Ryde  <user42@zip.com.au>

	* textmodes/sgml-mode.el (sgml-lexical-context): Recognise
	comment-start-skip to comment-end-skip as `comment' instead of `tag'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: sgml-mode.el.lexical-comment.diff --]
[-- Type: text/x-diff, Size: 1049 bytes --]

Index: sgml-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/sgml-mode.el,v
retrieving revision 1.143
diff -u -u -r1.143 sgml-mode.el
--- sgml-mode.el	18 Oct 2009 22:25:40 -0000	1.143
+++ sgml-mode.el	21 Oct 2009 23:02:02 -0000
@@ -1048,6 +1048,12 @@
                   (let ((cdata-start (point)))
                     (unless (search-forward "]]>" pos 'move)
                       (list 0 nil nil 'cdata nil nil nil nil cdata-start))))
+                 ((looking-at comment-start-skip)
+		  ;; parse-partial-sexp doesn't handle <!-- comments -->,
+		  ;; or only if ?- is in sgml-specials, so match explicitly
+                  (let ((start (point)))
+                    (unless (re-search-forward comment-end-skip pos 'move)
+                      (list 0 nil nil nil t nil nil nil start))))
                  ((and sgml-xml-mode (looking-at "<\\?"))
                   ;; Processing Instructions.
                   ;; In SGML, it's basically a normal tag of the form

[-- Attachment #2.1.3: Type: text/plain, Size: 1076 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

[-- Attachment #3: Type: message/rfc822, Size: 1885 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 4781-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1; sgml-lexical-context on <!-- comments
Date: Sat, 05 Dec 2009 15:23:39 -0500
Message-ID: <87bpidb25w.fsf@stupidchicken.com>

> In a file foo.html containing
>
>     <!-- foo -->
>
> and in html-mode with point on the "foo", calling `sgml-lexical-context'
> returns
>
>     (tag . 1)
>
> where I thought from the docstring of that function it would be
>
>     (comment . 1)
>
> I suppose parse-partial-sexp doesn't quite recognise <!--, or not
> without the sgml-specials hack.  I get some joy from the lines below.

Thanks, I've checked your patch into the repository.