unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#9393: 24.0.50; Tiny bug in info node "(elisp)Building Lists"
@ 2011-08-28 13:29 Dani Moncayo
  2011-08-28 13:45 ` Dani Moncayo
  2011-09-03  7:33 ` bug#9393: 24.0.50; Typo in Elisp manual Dani Moncayo
  0 siblings, 2 replies; 8+ messages in thread
From: Dani Moncayo @ 2011-08-28 13:29 UTC (permalink / raw)
  To: 9393

tags: patch

In info node "(elisp)Building Lists", I've found a small error, which
is fixed by the below patch.

=== modified file 'doc/lispref/lists.texi'
--- doc/lispref/lists.texi      2011-05-29 22:41:06 +0000
+++ doc/lispref/lists.texi      2011-08-28 13:15:35 +0000
@@ -463,7 +463,7 @@
 @end group
 @group
 (setq l (make-list 3 '(a b))
-     @result{} ((a b) (a b) (a b))
+     @result{} ((a b) (a b) (a b)))
 (eq (car l) (cadr l))
      @result{} t
 @end group



-- 
Dani Moncayo





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Tiny bug in info node "(elisp)Building Lists"
  2011-08-28 13:29 bug#9393: 24.0.50; Tiny bug in info node "(elisp)Building Lists" Dani Moncayo
@ 2011-08-28 13:45 ` Dani Moncayo
  2011-08-28 19:08   ` Chong Yidong
  2011-09-03  7:33 ` bug#9393: 24.0.50; Typo in Elisp manual Dani Moncayo
  1 sibling, 1 reply; 8+ messages in thread
From: Dani Moncayo @ 2011-08-28 13:45 UTC (permalink / raw)
  To: 9393

Sorry, the previous patch is obviously wrong.  This is the right one:


=== modified file 'doc/lispref/lists.texi'
--- doc/lispref/lists.texi      2011-05-29 22:41:06 +0000
+++ doc/lispref/lists.texi      2011-08-28 13:43:12 +0000
@@ -462,7 +462,7 @@
      @result{} nil
 @end group
 @group
-(setq l (make-list 3 '(a b))
+(setq l (make-list 3 '(a b)))
      @result{} ((a b) (a b) (a b))
 (eq (car l) (cadr l))
      @result{} t



-- 
Dani Moncayo





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Tiny bug in info node "(elisp)Building Lists"
  2011-08-28 13:45 ` Dani Moncayo
@ 2011-08-28 19:08   ` Chong Yidong
  0 siblings, 0 replies; 8+ messages in thread
From: Chong Yidong @ 2011-08-28 19:08 UTC (permalink / raw)
  To: Dani Moncayo; +Cc: 9393

Dani Moncayo <dmoncayo@gmail.com> writes:

> Sorry, the previous patch is obviously wrong.  This is the right one:

Thanks, applied.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Typo in Elisp manual
  2011-08-28 13:29 bug#9393: 24.0.50; Tiny bug in info node "(elisp)Building Lists" Dani Moncayo
  2011-08-28 13:45 ` Dani Moncayo
@ 2011-09-03  7:33 ` Dani Moncayo
  2011-09-14  6:53   ` Glenn Morris
  2011-10-02  9:04   ` Dani Moncayo
  1 sibling, 2 replies; 8+ messages in thread
From: Dani Moncayo @ 2011-09-03  7:33 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 9393

I think I've found another typo in node "(elisp)Sets And Lists":


=== modified file 'doc/lispref/lists.texi'
--- doc/lispref/lists.texi      2011-05-29 22:41:06 +0000
+++ doc/lispref/lists.texi      2011-08-29 15:45:15 +0000
@@ -1454,7 +1454,7 @@
 l
      @result{} ((2) (1))
 ;; @r{If you want to change @code{l} reliably,}
-;; @r{write @code{(setq l (delete elt l))}.}
+;; @r{write @code{(setq l (delete '(2) l))}.}
 @end group
 @group
 (setq l '((2) (1) (2)))


In the example at hand `elt' is unknown, so that `(setq l (delete elt
l))' has no sense and raises an error.

-- 
Dani Moncayo





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Typo in Elisp manual
  2011-09-03  7:33 ` bug#9393: 24.0.50; Typo in Elisp manual Dani Moncayo
@ 2011-09-14  6:53   ` Glenn Morris
  2011-10-02  9:04   ` Dani Moncayo
  1 sibling, 0 replies; 8+ messages in thread
From: Glenn Morris @ 2011-09-14  6:53 UTC (permalink / raw)
  To: Dani Moncayo; +Cc: Chong Yidong, 9393


Thanks; applied.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Typo in Elisp manual
  2011-09-03  7:33 ` bug#9393: 24.0.50; Typo in Elisp manual Dani Moncayo
  2011-09-14  6:53   ` Glenn Morris
@ 2011-10-02  9:04   ` Dani Moncayo
  2011-10-02 18:21     ` Glenn Morris
  1 sibling, 1 reply; 8+ messages in thread
From: Dani Moncayo @ 2011-10-02  9:04 UTC (permalink / raw)
  To: 9393

Hi,

Info node "(elisp)Advising Functions" begins with:

> The "advice" feature lets you add to the existing definition of a
> function, by "advising the function".

Please, correct me if I'm wrong (English is not my first language),
but I think that this sentence is lacking a substantive just after
"lets you add".  For example: "... lets you add code to the existing
..."



-- 
Dani Moncayo





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Typo in Elisp manual
  2011-10-02  9:04   ` Dani Moncayo
@ 2011-10-02 18:21     ` Glenn Morris
  2011-10-03  6:28       ` Dani Moncayo
  0 siblings, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2011-10-02 18:21 UTC (permalink / raw)
  To: Dani Moncayo; +Cc: 9393

Dani Moncayo wrote:

>> The "advice" feature lets you add to the existing definition of a
>> function, by "advising the function".
>
> Please, correct me if I'm wrong (English is not my first language),
> but I think that this sentence is lacking a substantive just after
> "lets you add".  For example: "... lets you add code to the existing
> ..."

The current wording seems fine to me. The OED says that "add" can be
used intransitively with "to", in the sense of "making something more
extensive".





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#9393: 24.0.50; Typo in Elisp manual
  2011-10-02 18:21     ` Glenn Morris
@ 2011-10-03  6:28       ` Dani Moncayo
  0 siblings, 0 replies; 8+ messages in thread
From: Dani Moncayo @ 2011-10-03  6:28 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 9393

>>> The "advice" feature lets you add to the existing definition of a
>>> function, by "advising the function".
>>
>> Please, correct me if I'm wrong (English is not my first language),
>> but I think that this sentence is lacking a substantive just after
>> "lets you add".  For example: "... lets you add code to the existing
>> ..."
>
> The current wording seems fine to me. The OED says that "add" can be
> used intransitively with "to", in the sense of "making something more
> extensive".

Thanks Glenn, noted.

[This report is already closed, so there's nothing else to do.]

-- 
Dani Moncayo





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-10-03  6:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-28 13:29 bug#9393: 24.0.50; Tiny bug in info node "(elisp)Building Lists" Dani Moncayo
2011-08-28 13:45 ` Dani Moncayo
2011-08-28 19:08   ` Chong Yidong
2011-09-03  7:33 ` bug#9393: 24.0.50; Typo in Elisp manual Dani Moncayo
2011-09-14  6:53   ` Glenn Morris
2011-10-02  9:04   ` Dani Moncayo
2011-10-02 18:21     ` Glenn Morris
2011-10-03  6:28       ` Dani Moncayo

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).