* bug#13465: 24.3.50; mml attached gpg signature filename convention
@ 2013-01-16 19:27 Milan Santosi
2013-01-16 22:35 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Milan Santosi @ 2013-01-16 19:27 UTC (permalink / raw)
To: 13465
Minor bug / cosmetics.
I've been exchanging signed emails using Emacs recently and noticed that
unlike others (non-emacsers), the filename of my attached signature is
always "noname" instead of "signature.asc".
Help from #emacs on freenode leads me to line 719 in rmailmm.el where I
find the "noname" hardcoded. Shouldn't this read "signature.asc"
instead (which seems conventional)?
kind regards,
Milan Santosi
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13465: 24.3.50; mml attached gpg signature filename convention
2013-01-16 19:27 bug#13465: 24.3.50; mml attached gpg signature filename convention Milan Santosi
@ 2013-01-16 22:35 ` Glenn Morris
2013-01-17 6:14 ` Milan Santosi
2013-05-06 7:17 ` Glenn Morris
0 siblings, 2 replies; 5+ messages in thread
From: Glenn Morris @ 2013-01-16 22:35 UTC (permalink / raw)
To: Milan Santosi; +Cc: 13465
Milan Santosi wrote:
> I've been exchanging signed emails using Emacs recently and noticed that
> unlike others (non-emacsers), the filename of my attached signature is
> always "noname" instead of "signature.asc".
>
> Help from #emacs on freenode leads me to line 719 in rmailmm.el where I
> find the "noname" hardcoded. Shouldn't this read "signature.asc"
> instead (which seems conventional)?
Are you asking for mml-secure-sign to use:
Content-Type: application/pgp-signature; name="signature.asc"
rather than the current:
Content-Type: application/pgp-signature
in what it sends out; or for Rmail to default to a filename of
"signature.asc" rather than "noname" for an application/pgp-signature
entity that does not specify a filename?
*** lisp/gnus/mml2015.el 2013-01-02 16:13:04 +0000
--- lisp/gnus/mml2015.el 2013-01-16 22:32:25 +0000
***************
*** 1069,1075 ****
(insert (format "\n--%s\n" boundary))
(goto-char (point-max))
(insert (format "\n--%s\n" boundary))
! (insert "Content-Type: application/pgp-signature\n\n")
(insert signature)
(goto-char (point-max))
(insert (format "--%s--\n" boundary))
--- 1069,1075 ----
(insert (format "\n--%s\n" boundary))
(goto-char (point-max))
(insert (format "\n--%s\n" boundary))
! (insert "Content-Type: application/pgp-signature; name=\"signature.asc\"\n\n")
(insert signature)
(goto-char (point-max))
(insert (format "--%s--\n" boundary))
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#13465: 24.3.50; mml attached gpg signature filename convention
2013-01-16 22:35 ` Glenn Morris
@ 2013-01-17 6:14 ` Milan Santosi
2013-01-17 6:39 ` Glenn Morris
2013-05-06 7:17 ` Glenn Morris
1 sibling, 1 reply; 5+ messages in thread
From: Milan Santosi @ 2013-01-17 6:14 UTC (permalink / raw)
To: Glenn Morris; +Cc: Milan Santosi, 13465
Thanks a lot for the patch!
> default to a filename of "signature.asc" rather than "noname" for an
> application/pgp-signature entity that does not specify a filename?
Yes, this is what I meant.
I found it a little bit odd for the hardcoded default to be "noname",
maybe it makes sense to change it to "signature.asc".
regards,
Milan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13465: 24.3.50; mml attached gpg signature filename convention
2013-01-17 6:14 ` Milan Santosi
@ 2013-01-17 6:39 ` Glenn Morris
0 siblings, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2013-01-17 6:39 UTC (permalink / raw)
To: Milan Santosi; +Cc: 13465
Milan Santosi wrote:
> Thanks a lot for the patch!
>
>> default to a filename of "signature.asc" rather than "noname" for an
>> application/pgp-signature entity that does not specify a filename?
> Yes, this is what I meant.
>
> I found it a little bit odd for the hardcoded default to be "noname",
> maybe it makes sense to change it to "signature.asc".
It is not at all odd because this is generic code for handling
attachments, not something specific for each possible attachment type.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#13465: 24.3.50; mml attached gpg signature filename convention
2013-01-16 22:35 ` Glenn Morris
2013-01-17 6:14 ` Milan Santosi
@ 2013-05-06 7:17 ` Glenn Morris
1 sibling, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2013-05-06 7:17 UTC (permalink / raw)
To: 13465-done
Version: 24.4
Glenn Morris wrote:
> mml-secure-sign to use:
>
> Content-Type: application/pgp-signature; name="signature.asc"
Done.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-06 7:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 19:27 bug#13465: 24.3.50; mml attached gpg signature filename convention Milan Santosi
2013-01-16 22:35 ` Glenn Morris
2013-01-17 6:14 ` Milan Santosi
2013-01-17 6:39 ` Glenn Morris
2013-05-06 7:17 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).