* bug#24726: 25.1; Small typo/bug in bookmark.el
@ 2016-10-18 8:07 Allen Li
2017-04-08 22:21 ` bug#24726: [PATCH] " Allen Li
0 siblings, 1 reply; 3+ messages in thread
From: Allen Li @ 2016-10-18 8:07 UTC (permalink / raw)
To: 24726
There appears to be a small typo in bookmark.el's
`bookmark-set-internal', which uses "(default: \"%s\")" for its
minibuffer prompt instead of "(default \"%s\")" (note the colon). This
causes `minibuffer-electric-default-mode' some grief.
In GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9)
of 2016-09-18 built on juergen
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --with-x-toolkit=gtk3 --with-xft
'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe
-fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#24726: [PATCH] Small typo/bug in bookmark.el
2016-10-18 8:07 bug#24726: 25.1; Small typo/bug in bookmark.el Allen Li
@ 2017-04-08 22:21 ` Allen Li
2018-06-06 0:34 ` Noam Postavsky
0 siblings, 1 reply; 3+ messages in thread
From: Allen Li @ 2017-04-08 22:21 UTC (permalink / raw)
To: 24726
The standard default format (per `minibuffer-electric-default-mode')
does not use a colon.
---
lisp/bookmark.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 5b8ded7b22..8c33d13c55 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -802,7 +802,7 @@ bookmark-set-internal
(let ((str
(or name
(read-from-minibuffer
- (format "%s (default: \"%s\"): " prompt default)
+ (format "%s (default \"%s\"): " prompt default)
nil
bookmark-minibuffer-read-name-map
nil nil defaults))))
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#24726: [PATCH] Small typo/bug in bookmark.el
2017-04-08 22:21 ` bug#24726: [PATCH] " Allen Li
@ 2018-06-06 0:34 ` Noam Postavsky
0 siblings, 0 replies; 3+ messages in thread
From: Noam Postavsky @ 2018-06-06 0:34 UTC (permalink / raw)
To: Allen Li; +Cc: 24726
tags 24726 fixed
close 24726 26.2
quit
Allen Li <darkfeline@felesatra.moe> writes:
> - (format "%s (default: \"%s\"): " prompt default)
> + (format "%s (default \"%s\"): " prompt default)
Pushed to emacs-26.
[1: d20beef5f1]: 2018-06-05 20:29:22 -0400
Fix prompt in bookmark.el (Bug#24726)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d20beef5f104909f765430e347f5f3711ea51149>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-06 0:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18 8:07 bug#24726: 25.1; Small typo/bug in bookmark.el Allen Li
2017-04-08 22:21 ` bug#24726: [PATCH] " Allen Li
2018-06-06 0:34 ` Noam Postavsky
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).