From: Noam Postavsky <npostavs@gmail.com>
To: Michael Hendricks <michael@ndrix.org>
Cc: 31139@debbugs.gnu.org
Subject: bug#31139: [PATCH] Document Narrow indicator in describe-mode
Date: Thu, 19 Apr 2018 08:16:50 -0400 [thread overview]
Message-ID: <87po2vs85p.fsf@gmail.com> (raw)
In-Reply-To: <20180412171208.79685-1-michael@ndrix.org> (Michael Hendricks's message of "Thu, 12 Apr 2018 11:12:08 -0600")
Michael Hendricks <michael@ndrix.org> writes:
> You're right that narrowing isn't exactly a minor mode. However,
> standard-mode-line-format includes narrowing information as part of
> mode-line-modes. So the narrowing indicator is rendered inside the
> same parentheses as indicators for true major and minor modes. Since
> describe-mode provides documentation for everything else that's inside
> those parentheses, it seemed appropriate to document narrowing in the
> same place.
Okay, I'm convinced. I think adding a comment along the lines of
"narrowing is not a minor mode, but its indicator is part of
mode-line-modes", would be helpful in case someone tries to "fix" your
change later.
> + (when (or (> (point-min) 1) (<= (point-max) (buffer-size)))
You should use buffer-narrowed-p instead of checking point min & max
here.
Have you assigned copyright for Emacs? (the patch is small enough to
install regardless, I'm asking just to know if it should be marked as a
tiny change).
next prev parent reply other threads:[~2018-04-19 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 17:12 bug#31139: [PATCH] Document Narrow indicator in describe-mode Michael Hendricks
2018-04-12 23:36 ` Noam Postavsky
2018-04-17 18:59 ` Michael Hendricks
2018-04-19 12:16 ` Noam Postavsky [this message]
2018-04-19 13:08 ` Eli Zaretskii
2018-04-19 14:38 ` Michael Hendricks
2018-04-19 14:44 ` Eli Zaretskii
2018-04-24 15:00 ` Michael Hendricks
2018-05-05 9:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po2vs85p.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31139@debbugs.gnu.org \
--cc=michael@ndrix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).