From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31139: [PATCH] Document Narrow indicator in describe-mode Date: Thu, 19 Apr 2018 08:16:50 -0400 Message-ID: <87po2vs85p.fsf@gmail.com> References: <20180412171208.79685-1-michael@ndrix.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524140173 17967 195.159.176.226 (19 Apr 2018 12:16:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 19 Apr 2018 12:16:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31139@debbugs.gnu.org To: Michael Hendricks Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 19 14:16:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f98Tw-0004ay-7M for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2018 14:16:08 +0200 Original-Received: from localhost ([::1]:43426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f98W2-00067T-D8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2018 08:18:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f98Vp-00066n-Lv for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 08:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f98Vm-0002yR-Gw for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 08:18:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f98Vm-0002y8-Bc for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 08:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f98Vm-00057B-0r for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Apr 2018 12:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31139-submit@debbugs.gnu.org id=B31139.152414022219590 (code B ref 31139); Thu, 19 Apr 2018 12:18:01 +0000 Original-Received: (at 31139) by debbugs.gnu.org; 19 Apr 2018 12:17:02 +0000 Original-Received: from localhost ([127.0.0.1]:60188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f98Un-00055h-RQ for submit@debbugs.gnu.org; Thu, 19 Apr 2018 08:17:02 -0400 Original-Received: from mail-io0-f179.google.com ([209.85.223.179]:43353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f98Uk-00055L-N4 for 31139@debbugs.gnu.org; Thu, 19 Apr 2018 08:16:59 -0400 Original-Received: by mail-io0-f179.google.com with SMTP id q84-v6so6317912iod.10 for <31139@debbugs.gnu.org>; Thu, 19 Apr 2018 05:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ox0CNu9XRw3m8qB3sONwENqEci7reSCB2Jm8dYwjit4=; b=Y8fGlLoHuvfg27XoaarkvjMaKeyoUVuaREg9myUQzMpSlqimP+Z6YqSbGeGQ/8k56W L9hwMtJaBamt5QPFyU9573mbVtcSDNq5Dfs5WoUcwb+OqlIA/elmH6m5Nc5/7eMsJjFx +s36zKphtirES3THfUSTmMmqIiOeJgGt/l+1obf1ZPWszp8Z54ca1hnt8aholYRIKL5c r2dpT1d3PtrDaINxiGS2fpOYP77FZtSwnIrs43hNhZ0zvYatmLJItQBtsgEHIV3fWaS/ yQad31FSPLqfHgRzA2pdMqvcHqf2IvM4P8dxUuRglkQRqa8mlQYSNef1dw/quBPIP52X QiTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ox0CNu9XRw3m8qB3sONwENqEci7reSCB2Jm8dYwjit4=; b=mvnaGpY5ddTPvC0Ea+0BN8F1rmHmQ4CBIU3f//+cMAIqMjDR9Of9ht2EXGK17iEOII fjhm59sy0xu/r5GtdlrdoLAOfw00g9ma91s9Vl9WS7QPRrxxTw9vKVyGx6+7Z/cb8pBo TvRL+rCdUadUkJG8Xahb3nv7t1920h5a9Zyvh0evmqix+KELYB/sU1juE20UW+NWTV+/ cjQuss8fjii7m/Jx1A/hhIcBqXrgCjanWQ1+uwnXn8QbupGU2BIi6GuDFsXKmRyIO2TP CMlsBCXuQHWz6kCqErjIugE2Q/hqOnspV/Udxp8EqhdwjlosEGWXBXFTXRz8y4SRsJF+ u9lA== X-Gm-Message-State: ALQs6tCxSyBA3Iyeqfq6IOIkeuvKqCjCrx+7uQtcabaeDGBAB/ipADLN 76zl2HdHZwNEy/FJFEwXSoWLew== X-Google-Smtp-Source: AIpwx48wRGh7vd/VR21DsTieP5PYBNaQuhz6A3XhWzL+bwwRF4sTw3hwBO29HhQt8qSNWskHVgo50Q== X-Received: by 2002:a6b:2a05:: with SMTP id q5-v6mr6190872ioq.252.1524140213054; Thu, 19 Apr 2018 05:16:53 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n73-v6sm2103904itb.23.2018.04.19.05.16.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 05:16:51 -0700 (PDT) In-Reply-To: <20180412171208.79685-1-michael@ndrix.org> (Michael Hendricks's message of "Thu, 12 Apr 2018 11:12:08 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145605 Archived-At: Michael Hendricks writes: > You're right that narrowing isn't exactly a minor mode. However, > standard-mode-line-format includes narrowing information as part of > mode-line-modes. So the narrowing indicator is rendered inside the > same parentheses as indicators for true major and minor modes. Since > describe-mode provides documentation for everything else that's inside > those parentheses, it seemed appropriate to document narrowing in the > same place. Okay, I'm convinced. I think adding a comment along the lines of "narrowing is not a minor mode, but its indicator is part of mode-line-modes", would be helpful in case someone tries to "fix" your change later. > + (when (or (> (point-min) 1) (<= (point-max) (buffer-size))) You should use buffer-narrowed-p instead of checking point min & max here. Have you assigned copyright for Emacs? (the patch is small enough to install regardless, I'm asking just to know if it should be marked as a tiny change).