From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: cohen@bu.edu, Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 37871@debbugs.gnu.org
Subject: bug#37871: 27.0.50; Merge feature/gnus-select2
Date: Sun, 06 Sep 2020 16:33:40 +0100 [thread overview]
Message-ID: <87pn6yudgr.fsf@tcd.ie> (raw)
In-Reply-To: <87a6y5ggba.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 04 Sep 2020 18:31:21 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> And it's in!
Thanks to everyone who worked on this!
I already pushed some minor code/doc cleanups to more closely follow
Emacs conventions in:
Fix formatting of recent Gnus nnselect changes
d7197f9d99 2020-09-06 16:06:57 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d7197f9d99ca6aa326d38e64ca9eb1d13e18d664
But I have some remaining comments.
First, the merge introduced the following build warning:
In end of data:
org/ol-gnus.el:271:1: Warning: the function ‘nnir-article-group’ is not known
to be defined.
Org should probably be updated to use the new names of things.
Second, several changes in gnus-msg.el have resulted in misindented code
of the form:
(unwind-protect
(progn
(one-single-form))
;; No unwind forms!
)
If the unwind-protect+progn wrappers are no longer needed, they should
be removed and the code reindented.
More worryingly, some of the changes that let-bind gnus-newsgroup-name
are preceded by the following commentary:
;; We can't `let' gnus-newsgroup-name here, since that leads
;; to local variables leaking.
If the leaking is still an issue, then the nnselect changes should be
reconsidered; otherwise these stale comments should be removed.
Third, the bodies of gnus-fetch-headers and nnheader-parse-nov are
misindented. (BTW, please respect the setting of indent-tabs-mode in
Emacs' top-level dir-locals-file, and especially don't use tab
characters for aligning comments to the right of code.)
Finally, the merge makes several backward-incompatible changes to user
options which should be rectified, lest we break existing user
configurations. The renamed user options gnus-refer-thread-use-nnir and
nnir-retrieve-headers-override-function should be defined as obsolete
varaliases for their new names gnus-refer-thread-use-search and
nnselect-retrieve-headers-override-function, respectively. Also, their
:version tags should be bumped to 28.1. The removed user option
nnir-summary-line-format should still be defined but made obsolete.
Thanks,
--
Basil
next prev parent reply other threads:[~2020-09-06 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 16:14 bug#37871: 27.0.50; Merge feature/gnus-select2 Eric Abrahamsen
2019-10-22 18:13 ` Lars Ingebrigtsen
2019-10-22 18:26 ` Eric Abrahamsen
2019-10-22 18:31 ` Lars Ingebrigtsen
2019-10-22 19:39 ` Eric Abrahamsen
2020-07-19 15:35 ` Lars Ingebrigtsen
2020-07-20 5:26 ` Eric Abrahamsen
2020-09-05 1:31 ` Eric Abrahamsen
2020-09-05 12:58 ` Lars Ingebrigtsen
2020-09-05 15:44 ` Eric Abrahamsen
2020-09-06 15:33 ` Basil L. Contovounesios [this message]
2020-09-06 22:53 ` Andrew Cohen
2020-10-15 16:04 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn6yudgr.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=37871@debbugs.gnu.org \
--cc=cohen@bu.edu \
--cc=eric@ericabrahamsen.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).