From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#37871: 27.0.50; Merge feature/gnus-select2 Date: Sun, 06 Sep 2020 16:33:40 +0100 Message-ID: <87pn6yudgr.fsf@tcd.ie> References: <87blu8lpu4.fsf@ericabrahamsen.net> <87sgnklkct.fsf@gnus.org> <87pniok558.fsf@ericabrahamsen.net> <87o8y8ljis.fsf@gnus.org> <87d0eok1t7.fsf@ericabrahamsen.net> <87pn8ro6vm.fsf@gnus.org> <874kq2bvun.fsf@ericabrahamsen.net> <87a6y5ggba.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 37871@debbugs.gnu.org To: cohen@bu.edu, Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 06 17:34:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEwgD-0001n5-94 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 17:34:09 +0200 Original-Received: from localhost ([::1]:59216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEwgC-0000EK-9u for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 11:34:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEwg6-0000ED-L1 for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 11:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEwg6-0002KC-Ap for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 11:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEwg6-00053l-8O for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 11:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Sep 2020 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37871 X-GNU-PR-Package: emacs Original-Received: via spool by 37871-submit@debbugs.gnu.org id=B37871.159940643419436 (code B ref 37871); Sun, 06 Sep 2020 15:34:02 +0000 Original-Received: (at 37871) by debbugs.gnu.org; 6 Sep 2020 15:33:54 +0000 Original-Received: from localhost ([127.0.0.1]:46859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEwfx-00053P-VE for submit@debbugs.gnu.org; Sun, 06 Sep 2020 11:33:54 -0400 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:38220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEwfs-000538-Hk for 37871@debbugs.gnu.org; Sun, 06 Sep 2020 11:33:53 -0400 Original-Received: by mail-ed1-f43.google.com with SMTP id c8so10279010edv.5 for <37871@debbugs.gnu.org>; Sun, 06 Sep 2020 08:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=hS2yJwQenc4Bq7qhbjEjaUMIdwkFCgukenymy42LGgk=; b=ZradmmsWsa9UwZBWaTFL2Dbuxc8lfsShGfg4XJ/FNwAGJT78i0N+RfA/n1riu0NrPL xkz3tHldUHFB6199L1bsfMRzLP8rfC6ysJNfqmWcZkcGz31C1/uFQulBIV8LlKIqYqlL YZgPYQ9T5GgNF6hjD38UBMoZF7FeAvjfM4KVS5w0WrVCJOuwK3lZYGUo/yRyKi3Kd1Mf 4StDLBwpkIZkwesYSk3J95HzBM7p09XYDz50Rnlx+jgUBcxIBBnxNrD09kf9YflAWnyt GuYwz33gHVc/KYqTcX7e1n6PhTU7Fxh7J9/6viWJOSxjeNXyV97XxS3Ot82VfX5J82hT bdWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hS2yJwQenc4Bq7qhbjEjaUMIdwkFCgukenymy42LGgk=; b=Kgrm8AjO9VyiiOqeATFhexkaBpIN2qKJhyCZxdNxF/Ntgq2Ot8fOuhfk+TWCihTaX2 tRplJITaERlRbL8Wt8TK2DfoPJEgn65/bCKwG6LVgzalWykxjo6a5wrxnEGcZKivGE+Z VS6r2MMlneMsOg6HsS5k77ATKeRCqi204KsLDC3WGR37tK0JdK6zRmDTv+fEAHTZd0AS 0jTPZbQEAOFAxdkLvWONUAyLj0wd2sJVqVYLrn/Tpq+YEJaDw8m42pCckeZ2B4x5AMYi sv0X43xDWcjKbWi4TtlctijcKHkcdkVJ+OEibOhPvneaA5pihtjMgVnpwgq9xQQUWiFC 1Jqw== X-Gm-Message-State: AOAM532pmF54e4nIqaJJxPAnw0Nqb4buoyN1PC+obB1pN8NoghFAJx94 PHCe2a+MxTnshc40vg8d8QbnCQ== X-Google-Smtp-Source: ABdhPJwmBg4iwvm6uZSCa+2K50UYNcL17Y04HmP6Us3m42paJ5NScAF8U50PaulKRutzGJige3dO2g== X-Received: by 2002:a05:6402:1773:: with SMTP id da19mr17104792edb.171.1599406422675; Sun, 06 Sep 2020 08:33:42 -0700 (PDT) Original-Received: from localhost ([109.77.32.127]) by smtp.gmail.com with ESMTPSA id s18sm12877588ejd.54.2020.09.06.08.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 08:33:42 -0700 (PDT) In-Reply-To: <87a6y5ggba.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 04 Sep 2020 18:31:21 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187350 Archived-At: Eric Abrahamsen writes: > And it's in! Thanks to everyone who worked on this! I already pushed some minor code/doc cleanups to more closely follow Emacs conventions in: Fix formatting of recent Gnus nnselect changes d7197f9d99 2020-09-06 16:06:57 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dd7197f9d99ca6aa326= d38e64ca9eb1d13e18d664 But I have some remaining comments. First, the merge introduced the following build warning: In end of data: org/ol-gnus.el:271:1: Warning: the function =E2=80=98nnir-article-group= =E2=80=99 is not known to be defined. Org should probably be updated to use the new names of things. Second, several changes in gnus-msg.el have resulted in misindented code of the form: (unwind-protect (progn (one-single-form)) ;; No unwind forms! ) If the unwind-protect+progn wrappers are no longer needed, they should be removed and the code reindented. More worryingly, some of the changes that let-bind gnus-newsgroup-name are preceded by the following commentary: ;; We can't `let' gnus-newsgroup-name here, since that leads ;; to local variables leaking. If the leaking is still an issue, then the nnselect changes should be reconsidered; otherwise these stale comments should be removed. Third, the bodies of gnus-fetch-headers and nnheader-parse-nov are misindented. (BTW, please respect the setting of indent-tabs-mode in Emacs' top-level dir-locals-file, and especially don't use tab characters for aligning comments to the right of code.) Finally, the merge makes several backward-incompatible changes to user options which should be rectified, lest we break existing user configurations. The renamed user options gnus-refer-thread-use-nnir and nnir-retrieve-headers-override-function should be defined as obsolete varaliases for their new names gnus-refer-thread-use-search and nnselect-retrieve-headers-override-function, respectively. Also, their :version tags should be bumped to 28.1. The removed user option nnir-summary-line-format should still be defined but made obsolete. Thanks, --=20 Basil