unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#18682: flymake-mode does not find makefiles named "makefile" or "GNUmakefile"
@ 2014-10-10 20:02 Rob Browning
  2021-05-29  3:30 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Browning @ 2014-10-10 20:02 UTC (permalink / raw)
  To: 18682; +Cc: 337339, 337339-forwarded, Josh Triplett

[If possible, please preserve the -forwarded address in replies.]

Looks like this was reported to flymake, and is even mentioned in a
comment in (24.3) flymake.el, but I thought there was a chance it should
be in the Emacs tracker too.

Josh Triplett <josh@freedesktop.org> writes:

> flymake-mode only searched for makefiles named "Makefile"; it will not
> find a makefile named "makefile" or "GNUmakefile".

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#18682: flymake-mode does not find makefiles named "makefile" or "GNUmakefile"
  2014-10-10 20:02 bug#18682: flymake-mode does not find makefiles named "makefile" or "GNUmakefile" Rob Browning
@ 2021-05-29  3:30 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-29  3:30 UTC (permalink / raw)
  To: Rob Browning
  Cc: 337339, 337339-forwarded, 18682, João Távora,
	Josh Triplett

Rob Browning <rlb@defaultvalue.org> writes:

> Looks like this was reported to flymake, and is even mentioned in a
> comment in (24.3) flymake.el, but I thought there was a chance it should
> be in the Emacs tracker too.
>
> Josh Triplett <josh@freedesktop.org> writes:
>
>> flymake-mode only searched for makefiles named "Makefile"; it will not
>> find a makefile named "makefile" or "GNUmakefile".

Looking at the flymake source code, this still seems to be the case in
Emacs 28.

It seems like this should be pretty easy to fix -- if we extend
`flymake-proc--init-find-buildfile-dir' to take a list of build file
names instead of a single file and then perhaps add a user option to
allow specifying the makefile names and use that in
`flymake-proc-simple-make-init' (etc.)?  (And have "Makefile" as the
first entry in that user option to preserve backwards compatibility.)

João, does that sound like a likely solution?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-29  3:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-10 20:02 bug#18682: flymake-mode does not find makefiles named "makefile" or "GNUmakefile" Rob Browning
2021-05-29  3:30 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).