* bug#49971: 28.0.50; indent-tabs-mode not working globally
@ 2021-08-09 21:15 Gabriel
2021-08-10 2:26 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Gabriel @ 2021-08-09 21:15 UTC (permalink / raw)
To: 49971
It seems that the new 'indent-tabs-mode' minor-mode, although defined as
global, it's working as a buffer-local minor-mode. Using emacs from
master branch built today:
1. emacs -Q
2. C-h v 'indent-tabs-mode' (value is t)
3. eval '(indent-tabs-mode -1)'
4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-09 21:15 bug#49971: 28.0.50; indent-tabs-mode not working globally Gabriel
@ 2021-08-10 2:26 ` Eli Zaretskii
2021-08-10 2:33 ` Gabriel
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2021-08-10 2:26 UTC (permalink / raw)
To: Gabriel; +Cc: 49971
> From: Gabriel <gabriel376@hotmail.com>
> Date: Mon, 09 Aug 2021 18:15:46 -0300
>
> It seems that the new 'indent-tabs-mode' minor-mode, although defined as
> global, it's working as a buffer-local minor-mode. Using emacs from
> master branch built today:
>
> 1. emacs -Q
> 2. C-h v 'indent-tabs-mode' (value is t)
> 3. eval '(indent-tabs-mode -1)'
> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
Where did you see that it's "defined as global"?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-10 2:26 ` Eli Zaretskii
@ 2021-08-10 2:33 ` Gabriel
2021-08-10 11:57 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Gabriel @ 2021-08-10 2:33 UTC (permalink / raw)
To: 49971
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Gabriel <gabriel376@hotmail.com>
>> Date: Mon, 09 Aug 2021 18:15:46 -0300
>>
>> It seems that the new 'indent-tabs-mode' minor-mode, although defined as
>> global, it's working as a buffer-local minor-mode. Using emacs from
>> master branch built today:
>>
>> 1. emacs -Q
>> 2. C-h v 'indent-tabs-mode' (value is t)
>> 3. eval '(indent-tabs-mode -1)'
>> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
>
> Where did you see that it's "defined as global"?
On simple.el:
(define-minor-mode indent-tabs-mode
"Toggle whether indentation can insert TAB characters."
:global t :group 'indent :variable indent-tabs-mode)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-10 2:33 ` Gabriel
@ 2021-08-10 11:57 ` Eli Zaretskii
2021-08-10 12:08 ` Andreas Schwab
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2021-08-10 11:57 UTC (permalink / raw)
To: Gabriel; +Cc: 49971
> From: Gabriel <gabriel376@hotmail.com>
> Date: Mon, 09 Aug 2021 23:33:37 -0300
>
> >> 1. emacs -Q
> >> 2. C-h v 'indent-tabs-mode' (value is t)
> >> 3. eval '(indent-tabs-mode -1)'
> >> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
> >
> > Where did you see that it's "defined as global"?
>
> On simple.el:
>
> (define-minor-mode indent-tabs-mode
> "Toggle whether indentation can insert TAB characters."
> :global t :group 'indent :variable indent-tabs-mode)
That's the mode, but in your recipe you are looking at the variable,
not the mode. And the documentation of the variable clearly says:
Automatically becomes buffer-local when set.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-10 11:57 ` Eli Zaretskii
@ 2021-08-10 12:08 ` Andreas Schwab
2021-08-10 13:30 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2021-08-10 12:08 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Gabriel, 49971
On Aug 10 2021, Eli Zaretskii wrote:
>> From: Gabriel <gabriel376@hotmail.com>
>> Date: Mon, 09 Aug 2021 23:33:37 -0300
>>
>> >> 1. emacs -Q
>> >> 2. C-h v 'indent-tabs-mode' (value is t)
>> >> 3. eval '(indent-tabs-mode -1)'
>> >> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
>> >
>> > Where did you see that it's "defined as global"?
>>
>> On simple.el:
>>
>> (define-minor-mode indent-tabs-mode
>> "Toggle whether indentation can insert TAB characters."
>> :global t :group 'indent :variable indent-tabs-mode)
>
> That's the mode, but in your recipe you are looking at the variable,
> not the mode. And the documentation of the variable clearly says:
>
> Automatically becomes buffer-local when set.
That's because it's explicitly made that way (bindings.el:799) despite
the :global declaration (which is about the _variable_ not the mode).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-10 12:08 ` Andreas Schwab
@ 2021-08-10 13:30 ` Eli Zaretskii
2021-08-10 13:40 ` Lars Ingebrigtsen
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2021-08-10 13:30 UTC (permalink / raw)
To: Andreas Schwab, Lars Ingebrigtsen; +Cc: gabriel376, 49971
> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Gabriel <gabriel376@hotmail.com>, 49971@debbugs.gnu.org
> Date: Tue, 10 Aug 2021 14:08:19 +0200
>
> On Aug 10 2021, Eli Zaretskii wrote:
>
> >> (define-minor-mode indent-tabs-mode
> >> "Toggle whether indentation can insert TAB characters."
> >> :global t :group 'indent :variable indent-tabs-mode)
> >
> > That's the mode, but in your recipe you are looking at the variable,
> > not the mode. And the documentation of the variable clearly says:
> >
> > Automatically becomes buffer-local when set.
>
> That's because it's explicitly made that way (bindings.el:799) despite
> the :global declaration (which is about the _variable_ not the mode).
Apologies. But then I don't understand why we'd want this to be a
global minor mode. Lars?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-10 13:30 ` Eli Zaretskii
@ 2021-08-10 13:40 ` Lars Ingebrigtsen
2022-08-22 12:02 ` Lars Ingebrigtsen
0 siblings, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2021-08-10 13:40 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gabriel376, Andreas Schwab, 49971
Eli Zaretskii <eliz@gnu.org> writes:
>> That's because it's explicitly made that way (bindings.el:799) despite
>> the :global declaration (which is about the _variable_ not the mode).
>
> Apologies. But then I don't understand why we'd want this to be a
> global minor mode. Lars?
Uhm... I think the :global t may be a mistake here -- I was just
following the suggestion in bug#6276 without thinking much about it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#49971: 28.0.50; indent-tabs-mode not working globally
2021-08-10 13:40 ` Lars Ingebrigtsen
@ 2022-08-22 12:02 ` Lars Ingebrigtsen
0 siblings, 0 replies; 8+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-22 12:02 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gabriel376, Andreas Schwab, 49971
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Uhm... I think the :global t may be a mistake here -- I was just
> following the suggestion in bug#6276 without thinking much about it.
I've now fixed this in Emacs 29.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-08-22 12:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 21:15 bug#49971: 28.0.50; indent-tabs-mode not working globally Gabriel
2021-08-10 2:26 ` Eli Zaretskii
2021-08-10 2:33 ` Gabriel
2021-08-10 11:57 ` Eli Zaretskii
2021-08-10 12:08 ` Andreas Schwab
2021-08-10 13:30 ` Eli Zaretskii
2021-08-10 13:40 ` Lars Ingebrigtsen
2022-08-22 12:02 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).