unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#50474: 28.0.50; whitespace-mode in non-editable Gnus buffers
@ 2021-09-08 13:21 Stephen Berman
  2021-09-08 13:26 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2021-09-08 13:21 UTC (permalink / raw)
  To: 50474

Enabling whitespace-mode in Gnus Group, Summary or Article buffers
removes the Gnus-specific fontification in these buffers.  This happens
when whitespace-color-on calls font-lock-add-keywords, which tests (and
font-lock-mode (not (or font-lock-keywords font-lock-defaults))), and in
the Gnus buffers font-lock-mode is t and font-lock-keywords and
font-lock-defaults are both nil, so the test succeeds and consequently
the following sexps are evaluated:

           (font-lock-mode -1)
           (setq-local font-lock-defaults '(nil t))
           (font-lock-mode 1)

which removes the buffer fontification.  Adding `(font-lock-mode -1)' to
the gnus-{group,summary,article}-mode definitions prevents this (i.e.,
keeps the Gnus-specific fontification), but then the whitespace-mode
faces are not applied to the Gnus buffers.


In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.29, cairo version 1.17.4)
 of 2021-09-08 built on strobelfs
Repository revision: 439ca062c830a7f3288a2dac48457edf5b1bfc59
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Linux From Scratch 10.2-rc1

Configured using:
 'configure --with-native-compilation 'CFLAGS=-Og -g3'
 PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM
GTK3 ZLIB





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#50474: 28.0.50; whitespace-mode in non-editable Gnus buffers
  2021-09-08 13:21 bug#50474: 28.0.50; whitespace-mode in non-editable Gnus buffers Stephen Berman
@ 2021-09-08 13:26 ` Lars Ingebrigtsen
  2021-09-08 13:48   ` Stephen Berman
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-09-08 13:26 UTC (permalink / raw)
  To: Stephen Berman; +Cc: 50474

Stephen Berman <stephen.berman@gmx.net> writes:

> Enabling whitespace-mode in Gnus Group, Summary or Article buffers
> removes the Gnus-specific fontification in these buffers. 

Yes, that's not supported -- none of the font locking stuff can be used
in Gnus buffers (since it controls the fonts itself).  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#50474: 28.0.50; whitespace-mode in non-editable Gnus buffers
  2021-09-08 13:26 ` Lars Ingebrigtsen
@ 2021-09-08 13:48   ` Stephen Berman
  2021-09-09 13:43     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2021-09-08 13:48 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 50474

On Wed, 08 Sep 2021 15:26:55 +0200 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> Enabling whitespace-mode in Gnus Group, Summary or Article buffers
>> removes the Gnus-specific fontification in these buffers.
>
> Yes, that's not supported -- none of the font locking stuff can be used
> in Gnus buffers (since it controls the fonts itself).

That's what I assumed, but is it documented?  (I briefly looked but
didn't see anything relevant.)  And although it's probably not too
common to enable whitespace-mode in a non-editable Gnus buffer, it is a
gotcha if you happen to do so.  It would be user-friendly to prevent
that, but maybe the effort isn't worth it.

Steve Berman





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#50474: 28.0.50; whitespace-mode in non-editable Gnus buffers
  2021-09-08 13:48   ` Stephen Berman
@ 2021-09-09 13:43     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-09-09 13:43 UTC (permalink / raw)
  To: Stephen Berman; +Cc: 50474

Stephen Berman <stephen.berman@gmx.net> writes:

> That's what I assumed, but is it documented?

Apparently not, so I've now added a paragraph to the Gnus manual about this.

> (I briefly looked but
> didn't see anything relevant.)  And although it's probably not too
> common to enable whitespace-mode in a non-editable Gnus buffer, it is a
> gotcha if you happen to do so.  It would be user-friendly to prevent
> that, but maybe the effort isn't worth it.

Yeah, I don't think it's worth it -- your report about this is the first
time I can recall somebody trying this in...  er...  has it been 30
years now?  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-09 13:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 13:21 bug#50474: 28.0.50; whitespace-mode in non-editable Gnus buffers Stephen Berman
2021-09-08 13:26 ` Lars Ingebrigtsen
2021-09-08 13:48   ` Stephen Berman
2021-09-09 13:43     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).