unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46853@debbugs.gnu.org, stefan@marxist.se
Subject: bug#46853: Confusing terminology "face height" instead of "font size"
Date: Mon, 20 Jun 2022 01:27:54 +0200	[thread overview]
Message-ID: <87pmj4s079.fsf@gnus.org> (raw)
In-Reply-To: <874khu3aiw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 01 Mar 2021 21:05:11 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> My understanding of what it does is:
>
> 1) The default face is definitely adjusted (even if it has an explicit
>    :height).
>
> 2) The header face is also adjusted (even if it has an explicit :height)
>    and you have that variable set.
>
> 3) All other fonts will also be adjusted, except those with an explicit
>    :height.
>
> There may be other rules, too (are there other face attributes that
> hinder size changes?), but this seems to indicate to me that we should
> just say (as in Stefan's patches) "changes the size of the fonts", and
> then link to a manual node that explains the three points above?

I've now applied Stefan's patch to Emacs 29, adjusting for most of Eli's
comments -- but not the ones about mentioning the default face as much.
Instead I've explicitly explained the above in both the manual and the
doc string, which should make things less confusing, I think.

Feel free to adjust further, of course.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2022-06-19 23:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 16:40 bug#46853: Confusing terminology "face height" instead of "font size" Stefan Kangas
2021-03-01 17:06 ` Eli Zaretskii
2021-03-01 19:31   ` Stefan Kangas
2021-03-01 19:46     ` Eli Zaretskii
2021-03-01 17:12 ` Lars Ingebrigtsen
2021-03-01 17:17   ` Eli Zaretskii
2021-03-01 19:15   ` Stefan Kangas
2021-03-01 19:25     ` Lars Ingebrigtsen
2021-03-01 19:33       ` Lars Ingebrigtsen
2021-03-01 19:37         ` Lars Ingebrigtsen
2021-03-01 19:50           ` Eli Zaretskii
2021-03-01 19:48         ` Eli Zaretskii
2021-03-01 20:05           ` Lars Ingebrigtsen
2021-03-01 20:17             ` Eli Zaretskii
2021-03-03 22:43               ` Stefan Kangas
2021-03-04 13:41                 ` Eli Zaretskii
2021-03-04 18:05                   ` Stefan Kangas
2022-06-19 23:27             ` Lars Ingebrigtsen [this message]
2021-03-01 19:35       ` Eli Zaretskii
2021-03-01 19:45         ` Lars Ingebrigtsen
2021-03-01 19:59           ` Eli Zaretskii
2021-03-04  0:16             ` Stefan Kangas
2021-03-04 13:46               ` Eli Zaretskii
2021-03-04 17:35                 ` Stefan Kangas
2021-03-01 19:33     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmj4s079.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=46853@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).