From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46853: Confusing terminology "face height" instead of "font size" Date: Mon, 20 Jun 2022 01:27:54 +0200 Message-ID: <87pmj4s079.fsf@gnus.org> References: <875z2a4x2c.fsf@gnus.org> <87tupu3cdd.fsf@gnus.org> <87pn0i3c0j.fsf@gnus.org> <83wnuq7izl.fsf@gnu.org> <874khu3aiw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 46853@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 20 01:29:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o34M4-00055p-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 01:29:20 +0200 Original-Received: from localhost ([::1]:35040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o34M3-0002Zn-OY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 19:29:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o34Ln-0002Z3-QP for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 19:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o34Ln-0001uu-5b for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 19:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o34Ln-00013Q-0k for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 19:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 23:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46853 X-GNU-PR-Package: emacs Original-Received: via spool by 46853-submit@debbugs.gnu.org id=B46853.16556812883915 (code B ref 46853); Sun, 19 Jun 2022 23:29:02 +0000 Original-Received: (at 46853) by debbugs.gnu.org; 19 Jun 2022 23:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:53429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o34Kt-000115-Ub for submit@debbugs.gnu.org; Sun, 19 Jun 2022 19:28:08 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o34Kr-00010X-3x for 46853@debbugs.gnu.org; Sun, 19 Jun 2022 19:28:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LJ1vTp2m0e0fgFiCk9G+s2dTec/GPa8YHXS4ckWWGQM=; b=qbljtv5ZaFuVey7t+TXzW61zMz Kd6fOMeln8KOmQFIIgu7rBCWBHr+vb2jhRo4Zc5jucqOTpysop3WBDsxYdgLbNYyUnwQzTVjreMlz NzYzGdQ97bPENvwKEDOwk3H0lFX24VqNKq93OvSP0fvFdIUWE5m71Bc8lx7NrbxRO5J4=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o34Kh-0003WQ-3M; Mon, 20 Jun 2022 01:27:58 +0200 In-Reply-To: <874khu3aiw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 01 Mar 2021 21:05:11 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234823 Archived-At: Lars Ingebrigtsen writes: > My understanding of what it does is: > > 1) The default face is definitely adjusted (even if it has an explicit > :height). > > 2) The header face is also adjusted (even if it has an explicit :height) > and you have that variable set. > > 3) All other fonts will also be adjusted, except those with an explicit > :height. > > There may be other rules, too (are there other face attributes that > hinder size changes?), but this seems to indicate to me that we should > just say (as in Stefan's patches) "changes the size of the fonts", and > then link to a manual node that explains the three points above? I've now applied Stefan's patch to Emacs 29, adjusting for most of Eli's comments -- but not the ones about mentioning the default face as much. Instead I've explicitly explained the above in both the manual and the doc string, which should make things less confusing, I think. Feel free to adjust further, of course. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no