From: Robert Pluim <rpluim@gmail.com>
To: 58718@debbugs.gnu.org
Cc: om@mailservice.ms, mattias.engdegard@gmail.com
Subject: bug#58718: Incorrect regex in nXML URI check
Date: Mon, 24 Oct 2022 14:26:08 +0200 [thread overview]
Message-ID: <87pmehqufz.fsf@gmail.com> (raw)
In-Reply-To: <0E0045FD-164C-4626-A81B-EF400FD04AD5@gmail.com> ("Mattias Engdegård"'s message of "Mon, 24 Oct 2022 12:51:30 +0200")
>>>>> On Mon, 24 Oct 2022 12:51:30 +0200, Mattias Engdegård <mattias.engdegard@gmail.com> said:
Mattias> I concur with the assessment. Your fixes are straightforward and have
Mattias> now been pushed to master.
Mattias> I also did a quick scan for similar errors (missing backslashes before
Mattias> curly brackets) but found no obvious cases of the same bug in the
Mattias> Emacs tree. A check could be added to the regexp linter but it's hard
Mattias> to guard against false positives.
Mattias> Thanks for the report and patch. This code hasn't seen much changes
Mattias> since it was added to Emacs, so if you find something else to improve
Mattias> you are more than welcome to contribute to further development.
If youʼre [1] looking at the code anyway, there might be opportunities to
use `url-unhex' and similar from 'url-utils.el' rather than
re-implementing the same function in nxml.
Robert
Footnotes:
[1] For the grammar pedants, of which Emacs appears to have many,
thatʼs a plural 'you' 😀
--
prev parent reply other threads:[~2022-10-24 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 12:58 bug#58718: Incorrect regex in nXML URI check Martin Jerabek
[not found] ` <handler.58718.B.16664517395858.ack@debbugs.gnu.org>
2022-10-23 10:46 ` bug#58718: Acknowledgement (Incorrect regex in nXML URI check) Martin Jerabek
2022-10-24 10:51 ` bug#58718: Incorrect regex in nXML URI check Mattias Engdegård
2022-10-24 12:26 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmehqufz.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=58718@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=om@mailservice.ms \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).