From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58718: Incorrect regex in nXML URI check Date: Mon, 24 Oct 2022 14:26:08 +0200 Message-ID: <87pmehqufz.fsf@gmail.com> References: <938384610b8c5411944afa7fae860f15e2e40eae.camel@fastmail.fm> <0E0045FD-164C-4626-A81B-EF400FD04AD5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: om@mailservice.ms, mattias.engdegard@gmail.com To: 58718@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 14:50:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omwuA-0004LT-NP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 14:50:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omwXx-0005je-Op; Mon, 24 Oct 2022 08:27:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omwXm-0005fg-Pe for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 08:27:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omwXm-0007Qe-HX for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 08:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omwXm-000545-5k for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 08:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Oct 2022 12:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58718 X-GNU-PR-Package: emacs Original-Received: via spool by 58718-submit@debbugs.gnu.org id=B58718.166661437719401 (code B ref 58718); Mon, 24 Oct 2022 12:27:02 +0000 Original-Received: (at 58718) by debbugs.gnu.org; 24 Oct 2022 12:26:17 +0000 Original-Received: from localhost ([127.0.0.1]:47328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omwX3-00052r-9Y for submit@debbugs.gnu.org; Mon, 24 Oct 2022 08:26:17 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:35546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omwX1-00052e-Jc for 58718@debbugs.gnu.org; Mon, 24 Oct 2022 08:26:15 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id l14so8717094wrw.2 for <58718@debbugs.gnu.org>; Mon, 24 Oct 2022 05:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GJL+J/KAAZZmuJLPROMpyPFJSxXBy+MMFqu5XeFGxmo=; b=KrvARINSWIdSNTJEAag6ABXeOYPTLqa0FT4GLccU6cUKWnv9Fzb4/hbrk9DkTTvPvv xjubj7QmWxjWreMDuKEHa1uqdLFfjl0gvYZN7iLDtJWYBsaiwq2DVpYEpfAWa0+5Gi6O GnO00huBrhR30eb+Q+GZVd18VP1gkxmOtY+wgMTP957Ku8zvOkq5X0jFsYBHjFgfIxGA X1wo2OM9iyZBmkdKZ4CMn5KMRlCWqd/6Azx64zoDqKah/z+a6fQ+X7p27YFoJd7I/AQZ tDSvqEwOTXKo4+sL6Cc+JKbTI2YRJylF+h2ADqC8QHwp6khM+WsISD/DQTD9X+WEULCj C0gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GJL+J/KAAZZmuJLPROMpyPFJSxXBy+MMFqu5XeFGxmo=; b=Ng7FKYoOEQRNg0M6OvKMeKp/KNj3rLJMOp2i4iwliaPomLjCYy73tuGavdGXinPVUT bKAjyBH1A+aiKpQT+CTaXXr8qlRk74g3vDUMgh4QcLYN/Xt6de8kL2IPmLjWxmDsfNMa SpI+E6lMT9XCjyXq6RSP6l+m6Bo1ZlWSz7Gfw6Bi86wIlLjBIunImi14Izg/oHxEnSDN W/I4cIgpP6IuZPaTjeW4SaYbyaLdg8J4UR0b4s06fXEIl7V48G6Q6tIfrnmfGaBETovr a2JzLsyVNWoWQ+X04OSk/G2kGFuGH7Wa5iaidhO9QIwuTxLyVd6gP4F653RH/YEK/rw/ cj4g== X-Gm-Message-State: ACrzQf1DkeOlhBVkVmtED0kx2ux4Monmc7H9QkVyQ2huqkuJFjb9emsy rrFAJ8iUuQgyDeSiGkOVX94= X-Google-Smtp-Source: AMsMyM6vVXavlTGwUJTjKVexOxjbDA0CPg8IyRNMIio2gSidvspVkYxXR5XgVik1eqcOCfSXxOXOSA== X-Received: by 2002:adf:e491:0:b0:236:5270:7f5e with SMTP id i17-20020adfe491000000b0023652707f5emr11465572wrm.600.1666614369452; Mon, 24 Oct 2022 05:26:09 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id i4-20020a05600011c400b002365cd93d05sm6949483wrx.102.2022.10.24.05.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 05:26:08 -0700 (PDT) In-Reply-To: <0E0045FD-164C-4626-A81B-EF400FD04AD5@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 24 Oct 2022 12:51:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246107 Archived-At: >>>>> On Mon, 24 Oct 2022 12:51:30 +0200, Mattias Engdeg=C3=A5rd said: Mattias> I concur with the assessment. Your fixes are straightforward a= nd have Mattias> now been pushed to master. Mattias> I also did a quick scan for similar errors (missing backslashe= s before Mattias> curly brackets) but found no obvious cases of the same bug in = the Mattias> Emacs tree. A check could be added to the regexp linter but it= 's hard Mattias> to guard against false positives. Mattias> Thanks for the report and patch. This code hasn't seen much ch= anges Mattias> since it was added to Emacs, so if you find something else to = improve Mattias> you are more than welcome to contribute to further development. If you=CA=BCre [1] looking at the code anyway, there might be opportunities= to use `url-unhex' and similar from 'url-utils.el' rather than re-implementing the same function in nxml. Robert Footnotes: [1] For the grammar pedants, of which Emacs appears to have many, that=CA=BCs a plural 'you' =F0=9F=98=80 --=20