unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: jostein@kjonigsen.net
Cc: 59735@debbugs.gnu.org
Subject: bug#59735: 29.0.60; csharp-ts-mode: imported namespaces are fontified inconsistently
Date: Thu, 01 Dec 2022 09:45:03 +0100	[thread overview]
Message-ID: <87pmd3zf5c.fsf@thornhill.no> (raw)
In-Reply-To: <ecd3c31b-5897-414b-b71b-64a6cd48aec6@app.fastmail.com>

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:

> When importing namespaces into your code, simple namespace-names are fontified as font-lock-type-name-face, while nested namespace-names are fontified as font-lock-variable-face-name.
>
> Example:
>
>   using System;    // font-lock-type-name-face
>   using System.IO; // font-lock-variable-name-face
>
> To be consistent internally, and with earlier implementations, all
> namespaces should be fontified using font-lock-variable-name-face.

Yeah, I agree.  I believe my plan was to make the last namespace
qualifier fontified with type-face, and the others in
variable-name-face.  It seems that didn't really work though ;)

With that idea in mind the code that fails is the second line, not the
first.

I don't have a strong preference there, so open to suggestions,
absolutely.

How does visual studio or vscode do it?


Theo

BTW, you should add CC's to the X-Debbugs-CC header, not as a normal CC.
That way I won't get CC'd until after the bug is created, and can reply
directly :)

Theo





  reply	other threads:[~2022-12-01  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <A77DCA47-9CBF-4506-9A90-B8080B0D901D@gmail.com>
2022-12-01  8:35 ` bug#59735: 29.0.60; csharp-ts-mode: imported namespaces are fontified inconsistently Jostein Kjønigsen
2022-12-01  8:45   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-12-01  9:23     ` Jostein Kjønigsen
2022-12-06  8:50       ` Jostein Kjønigsen
2022-12-06 10:22         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-06 21:43           ` Yuan Fu
     [not found]   ` <handler.59735.C.167037242622860.notifdonectrl.0@debbugs.gnu.org>
2022-12-12  8:24     ` bug#59735: acknowledged by developer (control message for bug #59735) Jostein Kjønigsen
2022-12-12 12:28       ` Jostein Kjønigsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmd3zf5c.fsf@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59735@debbugs.gnu.org \
    --cc=jostein@kjonigsen.net \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).