From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59735: 29.0.60; csharp-ts-mode: imported namespaces are fontified inconsistently Date: Thu, 01 Dec 2022 09:45:03 +0100 Message-ID: <87pmd3zf5c.fsf@thornhill.no> References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59735@debbugs.gnu.org To: jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 09:46:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0fDc-0001VY-TE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 09:46:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0fCp-0005DO-GK; Thu, 01 Dec 2022 03:46:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0fCl-0005Bh-Gm for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 03:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0fCl-0007Ju-44 for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 03:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0fCk-0006Yk-WF for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 03:46:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59735 X-GNU-PR-Package: emacs Original-Received: via spool by 59735-submit@debbugs.gnu.org id=B59735.166988430725173 (code B ref 59735); Thu, 01 Dec 2022 08:46:02 +0000 Original-Received: (at 59735) by debbugs.gnu.org; 1 Dec 2022 08:45:07 +0000 Original-Received: from localhost ([127.0.0.1]:38349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0fBr-0006Xx-E7 for submit@debbugs.gnu.org; Thu, 01 Dec 2022 03:45:07 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:17942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0fBp-0006Xq-NG for 59735@debbugs.gnu.org; Thu, 01 Dec 2022 03:45:06 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669884304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qU1EDRDnHunpsyNx2380kxhEq7JrxPkS3BRJt16CWUs=; b=Z8yFHKBlc0yk2ObEMuuwX880gzjhNJl+Knmr0KgtTu2KyNwtCjULXEXoLQs6AIlpndRmNC 3woA/awvolzOe8+ifNeB/bMLAZM0MmdyyWW/g87vxpwykMD7Q0MRxbO/DK0bapGoiHitUs 3Rsh3qm278n53rebdLTtp7XaqckBRhTeH2QpjHXxAoaVQHi9AKJMf4cvTmbROBkZYE1NJF OKyMC3gpmHghsCKQ5KEO0QHJtmr9dfN5fH19opJkRgeFuJYMmAz53vWFH2s8C7Rdp/VWO0 yBtSWbWShP8Bzvqm5v35DJbdeYO6nzl7sqpL7KNlyU2ik6TXs/0V37G+gHUdPA== In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249614 Archived-At: Jostein Kj=C3=B8nigsen writes: > When importing namespaces into your code, simple namespace-names are font= ified as font-lock-type-name-face, while nested namespace-names are fontifi= ed as font-lock-variable-face-name. > > Example: > > using System; // font-lock-type-name-face > using System.IO; // font-lock-variable-name-face > > To be consistent internally, and with earlier implementations, all > namespaces should be fontified using font-lock-variable-name-face. Yeah, I agree. I believe my plan was to make the last namespace qualifier fontified with type-face, and the others in variable-name-face. It seems that didn't really work though ;) With that idea in mind the code that fails is the second line, not the first. I don't have a strong preference there, so open to suggestions, absolutely. How does visual studio or vscode do it? Theo BTW, you should add CC's to the X-Debbugs-CC header, not as a normal CC. That way I won't get CC'd until after the bug is created, and can reply directly :) Theo