unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Davide Masserut via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, Stefan Kangas <stefankangas@gmail.com>,
	65509@debbugs.gnu.org
Subject: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries
Date: Sat, 02 Sep 2023 18:24:43 +0200	[thread overview]
Message-ID: <87pm303499.fsf@mssdvd.com> (raw)
In-Reply-To: <835y4tbtpj.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Fri, 1 Sep 2023 20:43:03 +0200
>> Cc: Eli Zaretskii <eliz@gnu.org>, Davide Masserut 
>> <dm@mssdvd.com>, 65509@debbugs.gnu.org
>>
>> forcemerge 64310 65509
>> thanks
>>
>> Po Lu writes:
>>
>> > I think this is the fix for the bug I couldn't reproduce 
>> > earlier,
>> > bug#64310.  The patch seems appropriate, thanks.
>>
>> >From the previous discussion, it seems like we wanted to get 
>> >this
>> fixed on emacs-29?
>>
>> Eli, WDYT?
>
> I don't know enough about these Freedesktop shortcuts to have an
> opinion.  If this is installed only for the PGTK build, and you 
> think
> it solves the problem, feel free to install on emacs-29.

For the same reason that the current emacsclient.desktop doesn't 
work with Wayland, installing the patch would break PGTK builds 
under Xorg because they would look for an environment variable 
that is not set by Xorg DEs.  Sorry, I've just noticed it.

We could choose to always open a new frame instead of reusing 
exiting ones. How does Emacs behave on other operating systems?





  reply	other threads:[~2023-09-02 16:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 18:32 bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-31  9:34 ` Eli Zaretskii
2023-08-31 11:32   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 18:43     ` Stefan Kangas
2023-09-01 19:04       ` Eli Zaretskii
2023-09-02 16:24         ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-02 16:58           ` Eli Zaretskii
2023-09-03  0:59             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03  5:34               ` Eli Zaretskii
2023-09-03  6:07                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 12:13                   ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 12:41                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 12:48                       ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 12:51                       ` Stefan Kangas
2023-09-03 13:00                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 13:31                           ` Stefan Kangas
2023-09-03 13:42                           ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04  0:38                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 14:46                               ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-06  0:07                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-06 14:01                                   ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07  8:26                                     ` Eli Zaretskii
2023-09-07  9:26                                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07  9:37                                         ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-08 15:49                                         ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15  7:05                                           ` Eli Zaretskii
2023-09-15  7:12                                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15  7:32                                               ` Eli Zaretskii
2023-09-15  7:44                                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 11:34                                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm303499.fsf@mssdvd.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=65509@debbugs.gnu.org \
    --cc=dm@mssdvd.com \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).