From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Davide Masserut via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Sat, 02 Sep 2023 18:24:43 +0200 Message-ID: <87pm303499.fsf@mssdvd.com> References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> Reply-To: Davide Masserut Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11956"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, Stefan Kangas , 65509@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 18:55:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcTtv-0002pX-B3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 18:55:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcTte-0000KU-R6; Sat, 02 Sep 2023 12:54:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTtd-0000Jm-Aj for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:54:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcTtd-0004PZ-2u for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:54:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcTtm-0004oB-Hi for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Davide Masserut Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65509-submit@debbugs.gnu.org id=B65509.169367367418426 (code B ref 65509); Sat, 02 Sep 2023 16:55:02 +0000 Original-Received: (at 65509) by debbugs.gnu.org; 2 Sep 2023 16:54:34 +0000 Original-Received: from localhost ([127.0.0.1]:38505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtG-0004n4-Rp for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:34 -0400 Original-Received: from out-233.mta0.migadu.com ([91.218.175.233]:34049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtB-0004mq-Iu for 65509@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693673654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vECKny6I+RztVEB6dNhoHYla18T7k5LnsUXVTIVL9XA=; b=fLWpSNlFAIyKKmR91BWzdvBRarCC8K5hO/c1H0hUwZlK9MDc5ciaQXXpNFsCZc7KiwiY+a FOPx9KMqaY1f8yeMy4LXgEFjuaS9H5uTix34/jVO7NUnJJ9A99gRHY+ZThExbxuN3Wu4Fn EmMpH0AbhGsS7b1DdfTTQ+2BZXHkPA7SCXT72kAdKqmCwh2Ftby95R8q8+OdM1Oay96E5A HLJ61CVSau95q+AHxpbVxu8QGDwL9U47F6JQXv9D6caX72EQbu4fsAf8ngdm8TUVt3iO/q LlB0nsuSciJtE2+HpCre0dt9sRQNe2v0lO8MmUQHJD64PRCmXjISuVBBfpbLVw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <835y4tbtpj.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269030 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Fri, 1 Sep 2023 20:43:03 +0200 >> Cc: Eli Zaretskii , Davide Masserut >> , 65509@debbugs.gnu.org >> >> forcemerge 64310 65509 >> thanks >> >> Po Lu writes: >> >> > I think this is the fix for the bug I couldn't reproduce >> > earlier, >> > bug#64310. The patch seems appropriate, thanks. >> >> >From the previous discussion, it seems like we wanted to get >> >this >> fixed on emacs-29? >> >> Eli, WDYT? > > I don't know enough about these Freedesktop shortcuts to have an > opinion. If this is installed only for the PGTK build, and you > think > it solves the problem, feel free to install on emacs-29. For the same reason that the current emacsclient.desktop doesn't work with Wayland, installing the patch would break PGTK builds under Xorg because they would look for an environment variable that is not set by Xorg DEs. Sorry, I've just noticed it. We could choose to always open a new frame instead of reusing exiting ones. How does Emacs behave on other operating systems?