From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 68214@debbugs.gnu.org
Subject: bug#68214: Completion sorting customization by category
Date: Sat, 06 Jan 2024 18:59:44 +0100 [thread overview]
Message-ID: <87plye9wbz.fsf@daniel-mendler.de> (raw)
In-Reply-To: <86r0iuxu4f.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 06 Jan 2024 19:33:36 +0200")
Juri Linkov <juri@linkov.net> writes:
>> If we are going with a solution which supports customizing arbitrary
>> metadata based on category, we could also adjust
>> `completion-metadata-get' and avoid the introduction of a separate
>> function `completion-metadata-override-get'. This will result in a
>> smaller and simpler code change overall.
>>
>> (defun completion-metadata-get (metadata prop)
>> "Get PROP from completion METADATA.
>> If the metadata specifies a completion category, the variables
>> `completion-category-overrides' and
>> `completion-category-defaults' take precedence."
>> (if-let (((not (eq prop 'category)))
>> (cat (alist-get 'category metadata))
>> (over (completion--category-override cat prop)))
>> (cdr over)
>> (alist-get prop metadata)))
>
> This is what I already considered but hesitated to make this change
> since it modifies the default behavior. OTOH, probably there is
> no possible harm from this change. So I'll give this a try.
Thanks. Seems better to take that route, instead of changing all
`completion-metadata-get' calls to `completion-metadata-override-get'
and leaving `completion-metadata-get' mostly unused. As long as we don't
modify `completion-category-defaults' or `completion-category-overrides'
there won't be a change in behavior.
next prev parent reply other threads:[~2024-01-06 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 17:07 bug#68214: Completion sorting customization by category Juri Linkov
2024-01-03 7:20 ` Daniel Mendler
2024-01-03 16:07 ` Juri Linkov
2024-01-03 17:12 ` Daniel Mendler
2024-01-04 17:21 ` Juri Linkov
2024-01-05 7:59 ` Juri Linkov
2024-01-05 8:33 ` Daniel Mendler
2024-01-06 17:33 ` Juri Linkov
2024-01-06 17:59 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-07 18:05 ` Juri Linkov
2024-01-07 18:37 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 17:59 ` Juri Linkov
2024-01-09 18:14 ` Juri Linkov
2024-01-09 18:31 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 7:35 ` Juri Linkov
2024-01-10 8:53 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plye9wbz.fsf@daniel-mendler.de \
--to=bug-gnu-emacs@gnu.org \
--cc=68214@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).