unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 68214@debbugs.gnu.org
Subject: bug#68214: Completion sorting customization by category
Date: Wed, 10 Jan 2024 09:35:41 +0200	[thread overview]
Message-ID: <86ply9myia.fsf@mail.linkov.net> (raw)
In-Reply-To: <87jzoiqryx.fsf@daniel-mendler.de> (Daniel Mendler's message of "Tue, 09 Jan 2024 19:31:02 +0100")

close 68214 30.0.50
thanks

>>> Now I tried to use a more user-friendly let-binding of
>>> 'completion-extra-properties' like below, but then discovered
>>> that it doesn't work for the category.
>>>
>>> Maybe 'completion-metadata-get' could try to get a category
>>> from 'completion-extra-properties' as well?
>>
>> Sorry, this was imprecise.  I meant another layer of indirection:
>> to get a category from 'completion-extra-properties'
>> to be able to get 'display-sort-function' by category.
>
> Indeed. I forgot about this indirection. This should be added as well.
> Not sure if there a significantly easier way to write this than as
> follows with a separate helper function?

I think other ways such as calling the same function recursively 
would be too ugly.  But a separate function is more clear.

> (defun completion--metadata-get-1 (metadata prop)
>   (or (alist-get prop metadata)
>       (plist-get completion-extra-properties
>                  ;; Cache the keyword
>                  (or (get prop 'completion-extra-properties--keyword)
>                      (put prop 'completion-extra-properties--keyword
>                           (intern (concat ":" (symbol-name prop))))))))
>
> (defun completion-metadata-get (metadata prop)

Now this is pushed as well.

Since all existing metadata functions are completely covered now,
it's time to close this feature request.

Thank you for helping to bring this nice feature to fruition!





  reply	other threads:[~2024-01-10  7:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 17:07 bug#68214: Completion sorting customization by category Juri Linkov
2024-01-03  7:20 ` Daniel Mendler
2024-01-03 16:07   ` Juri Linkov
2024-01-03 17:12     ` Daniel Mendler
2024-01-04 17:21       ` Juri Linkov
2024-01-05  7:59         ` Juri Linkov
2024-01-05  8:33           ` Daniel Mendler
2024-01-06 17:33             ` Juri Linkov
2024-01-06 17:59               ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 18:05                 ` Juri Linkov
2024-01-07 18:37                   ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 17:59                     ` Juri Linkov
2024-01-09 18:14                       ` Juri Linkov
2024-01-09 18:31                         ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10  7:35                           ` Juri Linkov [this message]
2024-01-10  8:53                             ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ply9myia.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=68214@debbugs.gnu.org \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).