* bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7.
@ 2023-10-12 21:16 Takesi Ayanokoji
2024-01-10 22:03 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Takesi Ayanokoji @ 2023-10-12 21:16 UTC (permalink / raw)
To: 66506
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
Hello,
When I tried building Android port of emacs-30.0.50 with modules, I
realized unnecessary hunk is included in the patch for
libjpeg-turbo-2.0.2/jconfig.h part of Android-ImageMagick7.
This hunk seems deletes empty lines only.
diff --git a/libjpeg-turbo-2.0.2/jconfig.h b/libjpeg-turbo-2.0.2/jconfig.h
index 47d14c9..5c6f8ee 100644
--- a/libjpeg-turbo-2.0.2/jconfig.h
+++ b/libjpeg-turbo-2.0.2/jconfig.h
@@ -1,57 +1,43 @@
-/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
+/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
#ifndef JPEG_LIB_VERSION
#define JPEG_LIB_VERSION 62
#endif
-
#ifndef LIBJPEG_TURBO_VERSION
#define LIBJPEG_TURBO_VERSION 2.0.2
#endif
-
#ifndef LIBJPEG_TURBO_VERSION_NUMBER
#define LIBJPEG_TURBO_VERSION_NUMBER 202
#endif
-
#ifndef C_ARITH_CODING_SUPPORTED
#define C_ARITH_CODING_SUPPORTED
#endif
-
#ifndef D_ARITH_CODING_SUPPORTED
#define D_ARITH_CODING_SUPPORTED
#endif
-
#ifndef MEM_SRCDST_SUPPORTED
#define MEM_SRCDST_SUPPORTED
#endif
-
#ifndef WITH_SIMD
#define WITH_SIMD
#endif
-
#ifndef BITS_IN_JSAMPLE
#define BITS_IN_JSAMPLE 8
#endif
-
#ifndef HAVE_LOCALE_H
#define HAVE_LOCALE_H
#endif
-
#ifndef HAVE_STDDEF_H
#define HAVE_STDDEF_H
#endif
-
#ifndef HAVE_STDLIB_H
#define HAVE_STDLIB_H
#endif
-
#ifndef NEED_SYS_TYPES_H
#define NEED_SYS_TYPES_H
#endif
-
#ifndef HAVE_UNSIGNED_CHAR
#define HAVE_UNSIGNED_CHAR
#endif
-
#ifndef HAVE_UNSIGNED_SHORT
#define HAVE_UNSIGNED_SHORT
#endif
-
Thanks,
[-- Attachment #2: Type: text/html, Size: 3107 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7.
2023-10-12 21:16 bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7 Takesi Ayanokoji
@ 2024-01-10 22:03 ` Stefan Kangas
2024-01-11 1:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2024-01-10 22:03 UTC (permalink / raw)
To: Takesi Ayanokoji; +Cc: 66506, Po Lu
Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:
> Hello,
>
> When I tried building Android port of emacs-30.0.50 with modules, I realized unnecessary hunk is included in the patch for
> libjpeg-turbo-2.0.2/jconfig.h part of Android-ImageMagick7.
>
> This hunk seems deletes empty lines only.
Po Lu, any comments?
>
> diff --git a/libjpeg-turbo-2.0.2/jconfig.h b/libjpeg-turbo-2.0.2/jconfig.h
> index 47d14c9..5c6f8ee 100644
> --- a/libjpeg-turbo-2.0.2/jconfig.h
> +++ b/libjpeg-turbo-2.0.2/jconfig.h
> @@ -1,57 +1,43 @@
> -/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
> +/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
> #ifndef JPEG_LIB_VERSION
> #define JPEG_LIB_VERSION 62
> #endif
> -
> #ifndef LIBJPEG_TURBO_VERSION
> #define LIBJPEG_TURBO_VERSION 2.0.2
> #endif
> -
> #ifndef LIBJPEG_TURBO_VERSION_NUMBER
> #define LIBJPEG_TURBO_VERSION_NUMBER 202
> #endif
> -
> #ifndef C_ARITH_CODING_SUPPORTED
> #define C_ARITH_CODING_SUPPORTED
> #endif
> -
> #ifndef D_ARITH_CODING_SUPPORTED
> #define D_ARITH_CODING_SUPPORTED
> #endif
> -
> #ifndef MEM_SRCDST_SUPPORTED
> #define MEM_SRCDST_SUPPORTED
> #endif
> -
> #ifndef WITH_SIMD
> #define WITH_SIMD
> #endif
> -
> #ifndef BITS_IN_JSAMPLE
> #define BITS_IN_JSAMPLE 8
> #endif
> -
> #ifndef HAVE_LOCALE_H
> #define HAVE_LOCALE_H
> #endif
> -
> #ifndef HAVE_STDDEF_H
> #define HAVE_STDDEF_H
> #endif
> -
> #ifndef HAVE_STDLIB_H
> #define HAVE_STDLIB_H
> #endif
> -
> #ifndef NEED_SYS_TYPES_H
> #define NEED_SYS_TYPES_H
> #endif
> -
> #ifndef HAVE_UNSIGNED_CHAR
> #define HAVE_UNSIGNED_CHAR
> #endif
> -
> #ifndef HAVE_UNSIGNED_SHORT
> #define HAVE_UNSIGNED_SHORT
> #endif
> -
>
> Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7.
2024-01-10 22:03 ` Stefan Kangas
@ 2024-01-11 1:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 18:24 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-01-11 1:25 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 66506, Takesi Ayanokoji
Stefan Kangas <stefankangas@gmail.com> writes:
> Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:
>
>> Hello,
>>
>> When I tried building Android port of emacs-30.0.50 with modules, I
>> realized unnecessary hunk is included in the patch for
>> libjpeg-turbo-2.0.2/jconfig.h part of Android-ImageMagick7.
>>
>> This hunk seems deletes empty lines only.
>
> Po Lu, any comments?
Parts of these patches are generated by a computer program, and since
one of its actions is to remove empty lines in a header file, that
should be reflected in the patches generated, if only for consistency's
sake.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7.
2024-01-11 1:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-01-11 18:24 ` Stefan Kangas
2024-01-12 1:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2024-01-11 18:24 UTC (permalink / raw)
To: Po Lu; +Cc: 66506, Takesi Ayanokoji
Po Lu <luangruo@yahoo.com> writes:
> Parts of these patches are generated by a computer program, and since
> one of its actions is to remove empty lines in a header file, that
> should be reflected in the patches generated, if only for consistency's
> sake.
What action do you propose here? Close as notabug?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7.
2024-01-11 18:24 ` Stefan Kangas
@ 2024-01-12 1:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 5+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-01-12 1:48 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 66506, Takesi Ayanokoji
tags 66506 notabug
close 66506
thanks
Stefan Kangas <stefankangas@gmail.com> writes:
> Po Lu <luangruo@yahoo.com> writes:
>
>> Parts of these patches are generated by a computer program, and since
>> one of its actions is to remove empty lines in a header file, that
>> should be reflected in the patches generated, if only for consistency's
>> sake.
>
> What action do you propose here? Close as notabug?
Yes, thanks. Now done.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-12 1:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 21:16 bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7 Takesi Ayanokoji
2024-01-10 22:03 ` Stefan Kangas
2024-01-11 1:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 18:24 ` Stefan Kangas
2024-01-12 1:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).