bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer'

bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer'

[Drew Adams]

1. I thought that distributed Emacs code was not supposed to use
`defadvice'.  `uniquify.el' uses it.
 
2. That advice makes the doc for `create-file-buffer' incorrect:
 
emacs -Q
 
C-h f create-file-buffer RET
 
There is nothing about the function being advised.
 
Now turn on `Use Directory Names in Buffer Names' from the `Options'
menu.
 
C-h f create-file-buffer RET
 
You now see this added to the doc string:
 
 This function is advised.
 
 After-advice `create-file-buffer-uniquify':
 Uniquify buffer names with parts of directory name.
 
Now turn using directory names back off again, using the same menu item.
 
C-h f create-file-buffer RET
 
still says the same thing.  It _seems_ to be saying (and it will be read
this way) that buffer names are currently being uniquified with parts of
buffer names - which is incorrect.
 
3. Besides all that, "uniquify" is not a word (OK, in English anyone can
invent a word, but it is not a well-known term).  So any such doc should
be rephrased to say what actually happens to the buffer name.
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-05-23 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include'
 

bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer'

[Lars Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

> 1. I thought that distributed Emacs code was not supposed to use
> `defadvice'.  `uniquify.el' uses it.
>
> 2. That advice makes the doc for `create-file-buffer' incorrect:
>
> emacs -Q
>
> C-h f create-file-buffer RET
>
> There is nothing about the function being advised.

And since uniquify is the default now, it should probably be fixed:

--------

create-file-buffer is a compiled Lisp function in `files.el'.

(create-file-buffer ARG1)

:around advice: `uniquify--create-file-buffer-advice'

--------


-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer'

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> And since uniquify is the default now, it should probably be fixed:
>
> --------
>
> create-file-buffer is a compiled Lisp function in `files.el'.
>
> (create-file-buffer ARG1)
>
> :around advice: `uniquify--create-file-buffer-advice'
>
> --------

And amusingly enough, there's this comment in the file:

;; The below solution works because generate-new-buffer-name is called
;; only by rename-buffer (which, as of 19.29, is never called from C) and
;; generate-new-buffer, which is called only by Lisp functions
;; create-file-buffer and rename-uniquely. 

This isn't...  er...  very true any more.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no