unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#19497: 24.4; erc-tls uses wrong default port number
@ 2015-01-03 21:17 Łukasz Stelmach
  2015-01-03 21:20 ` bug#19497: [PATCH] erc: use a differnt default port number for TLS connections Łukasz Stelmach
  2015-12-26  2:47 ` bug#19497: 24.4; erc-tls uses wrong default port number Lars Ingebrigtsen
  0 siblings, 2 replies; 3+ messages in thread
From: Łukasz Stelmach @ 2015-01-03 21:17 UTC (permalink / raw)
  To: 19497

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi,

By default `erc' suggests connecting to port 6667. As of now `erc-tls'
does not change this value as it should[1] to 6697.

A patch fixing this issue will follow this message.

[1] http://tools.ietf.org/html/rfc7194
-- 
Było mi bardzo miło.                                  --- Rurku. --- ...
>Łukasz<                                --- To dobrze, że mnie słuchasz.

... To była robota dla sześciu...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#19497: [PATCH] erc: use a differnt default port number for TLS connections.
  2015-01-03 21:17 bug#19497: 24.4; erc-tls uses wrong default port number Łukasz Stelmach
@ 2015-01-03 21:20 ` Łukasz Stelmach
  2015-12-26  2:47 ` bug#19497: 24.4; erc-tls uses wrong default port number Lars Ingebrigtsen
  1 sibling, 0 replies; 3+ messages in thread
From: Łukasz Stelmach @ 2015-01-03 21:20 UTC (permalink / raw)
  To: 19497; +Cc: Łukasz Stelmach

---
 lisp/erc/erc.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 7b9a3eb..999b794 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1456,6 +1456,10 @@ Defaults to the server buffer."
 (defconst erc-default-port 6667
   "IRC port to use if it cannot be detected otherwise.")
 
+(defconst erc-default-port-tls 6697
+  "IRC port to use for encrypted connections if it cannot be
+  detected otherwise.")
+
 (defcustom erc-join-buffer 'buffer
   "Determines how to display a newly created IRC buffer.
 
@@ -2185,7 +2189,8 @@ be invoked for the values of the other parameters."
 (defun erc-tls (&rest r)
   "Interactively select TLS connection parameters and run ERC.
 Arguments are the same as for `erc'."
-  (interactive (erc-select-read-args))
+  (interactive (let ((erc-default-port erc-default-port-tls))
+		 (erc-select-read-args)))
   (let ((erc-server-connect-function 'erc-open-tls-stream))
     (apply 'erc r)))
 
-- 
2.0.5






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#19497: 24.4; erc-tls uses wrong default port number
  2015-01-03 21:17 bug#19497: 24.4; erc-tls uses wrong default port number Łukasz Stelmach
  2015-01-03 21:20 ` bug#19497: [PATCH] erc: use a differnt default port number for TLS connections Łukasz Stelmach
@ 2015-12-26  2:47 ` Lars Ingebrigtsen
  1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2015-12-26  2:47 UTC (permalink / raw)
  To: Łukasz Stelmach; +Cc: 19497

Łukasz Stelmach <stlman@poczta.fm> writes:

> Hi,
>
> By default `erc' suggests connecting to port 6667. As of now `erc-tls'
> does not change this value as it should[1] to 6697.
>
> A patch fixing this issue will follow this message.
>
> [1] http://tools.ietf.org/html/rfc7194

Thanks; patch applied to trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-26  2:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-03 21:17 bug#19497: 24.4; erc-tls uses wrong default port number Łukasz Stelmach
2015-01-03 21:20 ` bug#19497: [PATCH] erc: use a differnt default port number for TLS connections Łukasz Stelmach
2015-12-26  2:47 ` bug#19497: 24.4; erc-tls uses wrong default port number Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).