* bug#23618: Some filenotify tests fail with extra "changed" events
@ 2016-05-25 16:55 Glenn Morris
2016-05-27 9:24 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2016-05-25 16:55 UTC (permalink / raw)
To: 23618; +Cc: michael.albinus
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
Package: emacs
Version: 25.0.94
Severity: minor
Some filenotify tests have failed for some time (always?) for me on RHEL 7.2.
Finally a report about it. In the past I've only ever seen one extra
"changed", never the silly number the following log includes! :)
PS as you can see from the log, these tests took ~ 15 minutes to run.
[-- Attachment #2: file-notify-tests.log.gz --]
[-- Type: application/octet-stream, Size: 1004 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-05-25 16:55 bug#23618: Some filenotify tests fail with extra "changed" events Glenn Morris
@ 2016-05-27 9:24 ` Michael Albinus
2016-05-27 16:38 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2016-05-27 9:24 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23618
Glenn Morris <rgm@gnu.org> writes:
Hi Glenn,
> Package: emacs
> Version: 25.0.94
> Severity: minor
>
> Some filenotify tests have failed for some time (always?) for me on RHEL 7.2.
> Finally a report about it. In the past I've only ever seen one extra
> "changed", never the silly number the following log includes! :)
Hard to say something about without debugging. Due to the nature of file
notification events, those `changed' events could appear from anywhere.
As you might imagine, I cannot reproduce the problems locally. Also
hydra does not report about.
The only exception is `file-notify-test08-watched-file-in-watched-dir-remote',
which has failed here as well. The remote `gvfs-monitor-dir' library is
a little bit fickle.
We have done some work in the master branch, which is not contained in
the emacs-25 branch. I don't see any problem running the tests in the
master branch. Do you see the problems also in the master branch?
It might be also interesting to know whether the failed tests appear
also during an ordinary "make check". I suppose you have applied "make
-C test/automated file-notify-tests", which runs the expensive tests.
> PS as you can see from the log, these tests took ~ 15 minutes to run.
Yes. The expensive tests contain tests with a looooot of events, because
some of the problems have appeared only in stress situations. On my
6-years-old laptop, running Ubuntu 16.04, the tests take ~12 minutes.
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-05-27 9:24 ` Michael Albinus
@ 2016-05-27 16:38 ` Glenn Morris
2016-05-27 18:00 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2016-05-27 16:38 UTC (permalink / raw)
To: Michael Albinus; +Cc: 23618
Michael Albinus wrote:
> We have done some work in the master branch, which is not contained in
> the emacs-25 branch. I don't see any problem running the tests in the
> master branch. Do you see the problems also in the master branch?
I do.
> It might be also interesting to know whether the failed tests appear
> also during an ordinary "make check".
Current master make check:
3 unexpected results:
FAILED file-notify-test02-events
FAILED file-notify-test04-file-validity
FAILED file-notify-test07-backup
Still due to extra "changed" events.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-05-27 16:38 ` Glenn Morris
@ 2016-05-27 18:00 ` Michael Albinus
2016-06-05 17:59 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2016-05-27 18:00 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23618
Glenn Morris <rgm@gnu.org> writes:
>> We have done some work in the master branch, which is not contained in
>> the emacs-25 branch. I don't see any problem running the tests in the
>> master branch. Do you see the problems also in the master branch?
>
> I do.
>
>> It might be also interesting to know whether the failed tests appear
>> also during an ordinary "make check".
>
> Current master make check:
>
> 3 unexpected results:
> FAILED file-notify-test02-events
> FAILED file-notify-test04-file-validity
> FAILED file-notify-test07-backup
>
> Still due to extra "changed" events.
OK, I'll try to get an RHEL 7.2 VM in order to reproduce it. Or maybe a
CentOS VM, in case RHEL VMs are not available.
In case it fails, I will send you an instrumentation patch for
filenotify-tests.el. We do agree that we work on the master branch,
don't we?
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-05-27 18:00 ` Michael Albinus
@ 2016-06-05 17:59 ` Michael Albinus
2016-06-07 21:23 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2016-06-05 17:59 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23618
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Glenn,
> OK, I'll try to get an RHEL 7.2 VM in order to reproduce it. Or maybe a
> CentOS VM, in case RHEL VMs are not available.
I haven't been able to reproduce the problems this way :-(
Anyway, the bug in `file-notify-test08-watched-file-in-watched-dir-remote'
I could fix (this was the only one I could reproduce locally).
Furthermore, I've added code to filenotify-tests.el in order to make it
more robust. That' means especially, that no events could arrive during
a test, resulting from a *previous* test. Maybe this fixes the other
problems already. Committed to the master branch.
> In case it fails, I will send you an instrumentation patch for
> filenotify-tests.el. We do agree that we work on the master branch,
> don't we?
In that case, pls apply the following patch
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/emacs/lisp/filenotify.el.~6627dd7c9405670db99b792f782aa94c5da118a9~ 2016-06-05 19:56:18.485624177 +0200
--- /home/albinus/src/emacs/lisp/filenotify.el 2016-06-05 19:56:02.353342656 +0200
***************
*** 86,92 ****
Otherwise, signal a `file-notify-error'."
(interactive "e")
! ;;(message "file-notify-handle-event %S" event)
(if (and (eq (car event) 'file-notify)
(>= (length event) 3))
(funcall (nth 2 event) (nth 1 event))
--- 86,92 ----
Otherwise, signal a `file-notify-error'."
(interactive "e")
! (message "file-notify-handle-event %S" event)
(if (and (eq (car event) 'file-notify)
(>= (length event) 3))
(funcall (nth 2 event) (nth 1 event))
***************
*** 261,270 ****
(and (stringp file1)
(string-equal
(nth 0 entry) (file-name-nondirectory file1)))))
! ;;(message
! ;;"file-notify-callback %S %S %S %S %S"
! ;;(file-notify--descriptor desc (car entry))
! ;;action file file1 registered)
(if file1
(funcall
callback
--- 261,270 ----
(and (stringp file1)
(string-equal
(nth 0 entry) (file-name-nondirectory file1)))))
! (message
! "file-notify-callback %S %S %S %S %S"
! (file-notify--descriptor desc (car entry))
! action file file1 registered)
(if file1
(funcall
callback
--8<---------------cut here---------------end--------------->8---
Hopefully, the logs will tell us what happens.
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-06-05 17:59 ` Michael Albinus
@ 2016-06-07 21:23 ` Glenn Morris
2016-06-20 12:46 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2016-06-07 21:23 UTC (permalink / raw)
To: Michael Albinus; +Cc: 23618
[-- Attachment #1: Type: text/plain, Size: 23 bytes --]
Please see attached.
[-- Attachment #2: filenotify-tests.log.xz --]
[-- Type: application/octet-stream, Size: 29308 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-06-07 21:23 ` Glenn Morris
@ 2016-06-20 12:46 ` Michael Albinus
2016-06-23 17:34 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2016-06-20 12:46 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23618
Hi Glenn,
I've stared on the logs for several days. Still unsure what happened. So
I've weakened the tests a little bit. Let's see how it works.
Thanks, and best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-06-20 12:46 ` Michael Albinus
@ 2016-06-23 17:34 ` Glenn Morris
2016-06-23 18:34 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2016-06-23 17:34 UTC (permalink / raw)
To: Michael Albinus; +Cc: 23618
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
It's better, thanks.
file-notify-test08-watched-file-in-watched-dir-remote still fails, for
impenetrable reasons. But it isn't run by default, so maybe it's time to
stop thinking about this now. The expensive tests are so slow, no-one
but you will ever run them anyway. ;)
[-- Attachment #2: filenotify-tests.log.xz --]
[-- Type: application/octet-stream, Size: 992 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23618: Some filenotify tests fail with extra "changed" events
2016-06-23 17:34 ` Glenn Morris
@ 2016-06-23 18:34 ` Michael Albinus
0 siblings, 0 replies; 9+ messages in thread
From: Michael Albinus @ 2016-06-23 18:34 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23618-done
Glenn Morris <rgm@gnu.org> writes:
> It's better, thanks.
Puh, finally ...
> file-notify-test08-watched-file-in-watched-dir-remote still fails, for
> impenetrable reasons. But it isn't run by default, so maybe it's time to
> stop thinking about this now. The expensive tests are so slow, no-one
> but you will ever run them anyway. ;)
It's not that bad, all created events have passed, and most of the
changed events. In reality I don't expect any problem, because changed
events appear more than once for a given change.
As you could assume, I have no problems locally. I guess it is a problem
of timing, but I don't want to increase the delays longer than they are.
Yes, let's close this bug. Thanks for your patient testing!
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-23 18:34 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 16:55 bug#23618: Some filenotify tests fail with extra "changed" events Glenn Morris
2016-05-27 9:24 ` Michael Albinus
2016-05-27 16:38 ` Glenn Morris
2016-05-27 18:00 ` Michael Albinus
2016-06-05 17:59 ` Michael Albinus
2016-06-07 21:23 ` Glenn Morris
2016-06-20 12:46 ` Michael Albinus
2016-06-23 17:34 ` Glenn Morris
2016-06-23 18:34 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).