From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net
Subject: bug#6695: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4)
Date: Sat, 15 Aug 2020 12:13:04 +0200 [thread overview]
Message-ID: <87o8nc1akv.fsf@gnus.org> (raw)
In-Reply-To: <83v9hkjmzb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Aug 2020 12:07:52 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> The c: isn't included, but is that to be expected?
>
> Is it? I thought the intent was to include the full file name, which
> means the drive letter should be included. Otherwise the file will
> not be found.
I don't have a Windows system to test with... it's possible that the
functions return the file name including the c: on a Windows machine?
>> So what do people think? Good or bad? Does this work in any way
>> sensibly for people?
>
> Since the heuristic only covers some use cases, I think we should have
> it off by default, and we should document its potential pitfalls in
> the doc string. With those qualifications, I'm okay with adding this
> optional feature.
OK, I've added some tests and pushed it to the trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-15 10:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 15:24 bug#8439: [PATCH] ffap.el -- detect paths with spaces Jari Aalto
2011-07-03 23:29 ` Lars Magne Ingebrigtsen
2012-10-19 7:39 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v2) Jari Aalto
2012-10-19 9:49 ` Eli Zaretskii
2012-10-19 10:05 ` jari
2012-10-19 11:15 ` Yigal Hochberg
2012-10-19 11:22 ` Eli Zaretskii
2012-10-19 12:15 ` Nicolas Richard
2012-10-19 21:47 ` Andrew W. Nosenko
2012-10-19 22:23 ` Eli Zaretskii
2012-10-19 22:36 ` Yigal Hochberg
2012-10-19 22:57 ` Andrew W. Nosenko
2012-10-19 23:24 ` Yigal Hochberg
2012-10-20 1:45 ` Stefan Monnier
2012-10-20 11:01 ` Juri Linkov
2012-10-19 8:35 ` Jari Aalto
2012-10-20 1:44 ` Stefan Monnier
2012-10-20 1:49 ` Daniel Colascione
2012-10-20 7:56 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v3) jari
2012-10-20 8:45 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) jari
2012-10-20 10:20 ` Eli Zaretskii
2012-10-21 0:18 ` Stefan Monnier
2012-10-21 8:07 ` Jari Aalto
2019-11-23 13:31 ` bug#6695: " Lars Ingebrigtsen
2020-08-14 13:08 ` Lars Ingebrigtsen
2020-08-15 9:07 ` Eli Zaretskii
2020-08-15 10:13 ` Lars Ingebrigtsen [this message]
2012-10-20 8:11 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v2) Eli Zaretskii
2012-10-21 0:16 ` Stefan Monnier
[not found] <<87pqoyaxu0.fsf@blue.sea.net>
[not found] ` <<87zk3i7tbu.fsf@picasso.cante.net>
[not found] ` <<jwvzk3ihr2i.fsf-monnier+emacs@gnu.org>
[not found] ` <<20121020075601.GD29154@picasso.cante.net>
[not found] ` <<20121020084551.GE29154@picasso.cante.net>
[not found] ` <<87mucmn2gs.fsf@gnus.org>
[not found] ` <<87tux574te.fsf@gnus.org>
[not found] ` <<83v9hkjmzb.fsf@gnu.org>
2020-08-15 19:33 ` bug#6695: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8nc1akv.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=6695@debbugs.gnu.org \
--cc=8439@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).