From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6695: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) Date: Sat, 15 Aug 2020 12:13:04 +0200 Message-ID: <87o8nc1akv.fsf@gnus.org> References: <87pqoyaxu0.fsf@blue.sea.net> <87zk3i7tbu.fsf@picasso.cante.net> <20121020075601.GD29154@picasso.cante.net> <20121020084551.GE29154@picasso.cante.net> <87mucmn2gs.fsf@gnus.org> <87tux574te.fsf@gnus.org> <83v9hkjmzb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24996"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 15 12:14:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tCT-0006OV-2S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 12:14:09 +0200 Original-Received: from localhost ([::1]:36358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6tCS-0004AM-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 06:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6tCM-0004A8-6j for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 06:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6tCL-0005YW-U2 for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 06:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6tCL-00027O-ON for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 06:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 10:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6695-submit@debbugs.gnu.org id=B6695.15974863988067 (code B ref 6695); Sat, 15 Aug 2020 10:14:01 +0000 Original-Received: (at 6695) by debbugs.gnu.org; 15 Aug 2020 10:13:18 +0000 Original-Received: from localhost ([127.0.0.1]:54279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tBe-000262-Cw for submit@debbugs.gnu.org; Sat, 15 Aug 2020 06:13:18 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tBa-00025h-DK; Sat, 15 Aug 2020 06:13:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uNbvnUnG7w6NOrkUyn7aSXZQOxhoyQnUZY4bkaQeKzQ=; b=eaxi4hfXpuEEBcbpPDqPeq/7Je 7WCQ6ETecdfHi6rDKZ6/8EmnlkvTdOAeXxMQ3iI0+XR29hSkD+12PLFwkOSiJRBPS4WGGYUR4apQR i6zF1cyXM/BNMnNMPcRiiFx66EBkbE2oWboiOUZ8rs1xEIfrpVFojrEnbj3ulWlJHB6k=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tBR-0006TE-3p; Sat, 15 Aug 2020 12:13:07 +0200 In-Reply-To: <83v9hkjmzb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Aug 2020 12:07:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185206 Archived-At: Eli Zaretskii writes: >> The c: isn't included, but is that to be expected? > > Is it? I thought the intent was to include the full file name, which > means the drive letter should be included. Otherwise the file will > not be found. I don't have a Windows system to test with... it's possible that the functions return the file name including the c: on a Windows machine? >> So what do people think? Good or bad? Does this work in any way >> sensibly for people? > > Since the heuristic only covers some use cases, I think we should have > it off by default, and we should document its potential pitfalls in > the doc string. With those qualifications, I'm okay with adding this > optional feature. OK, I've added some tests and pushed it to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no