From: Andreas Schwab <schwab@linux-m68k.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 45562@debbugs.gnu.org
Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm
Date: Fri, 01 Jan 2021 17:38:28 +0100 [thread overview]
Message-ID: <87o8i87gu3.fsf@igel.home> (raw)
In-Reply-To: <CADwFkmkm9YnTXdza0rU4dyQPyo6-R+6aswUasveKar+Z7--rrQ@mail.gmail.com> (Stefan Kangas's message of "Fri, 1 Jan 2021 10:21:24 -0600")
On Jan 01 2021, Stefan Kangas wrote:
>>> --- a/src/fns.c
>>> +++ b/src/fns.c
>>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length,
>>> if (c == '=')
>>> continue;
>>>
>>> - if (v1 < 0)
>>> - return -1;
Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-01-01 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 8:33 bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Stefan Kangas
2020-12-31 14:12 ` Eli Zaretskii
2021-01-01 11:08 ` Lars Ingebrigtsen
2021-01-01 11:37 ` Unknown
2021-01-01 16:10 ` Stefan Kangas
2021-01-01 12:05 ` Eli Zaretskii
2021-01-01 16:21 ` Stefan Kangas
2021-01-01 16:38 ` Andreas Schwab [this message]
2021-07-21 11:30 ` Lars Ingebrigtsen
2021-01-01 18:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8i87gu3.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=45562@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).