From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Date: Fri, 01 Jan 2021 17:38:28 +0100 Message-ID: <87o8i87gu3.fsf@igel.home> References: <83zh1ugj30.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21100"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) Cc: 45562@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 01 17:39:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvNSI-0005OU-Io for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Jan 2021 17:39:10 +0100 Original-Received: from localhost ([::1]:56628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvNSH-0005pp-L8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Jan 2021 11:39:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvNSA-0005pW-Gp for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2021 11:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvNSA-0008OW-9E for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2021 11:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvNSA-00077W-5S for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2021 11:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.160951911427337 (code B ref 45562); Fri, 01 Jan 2021 16:39:02 +0000 Original-Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 16:38:34 +0000 Original-Received: from localhost ([127.0.0.1]:34613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvNRi-00076r-9K for submit@debbugs.gnu.org; Fri, 01 Jan 2021 11:38:34 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.10]:35574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvNRf-00076h-GT for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 11:38:32 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4D6rLY5Ww8z1rwb1; Fri, 1 Jan 2021 17:38:29 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4D6rLY2zx2z1qr51; Fri, 1 Jan 2021 17:38:29 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id d_bdLfTbIS7W; Fri, 1 Jan 2021 17:38:28 +0100 (CET) X-Auth-Info: dGVmT0IrSdjuNQYqrb9mMHNv9Qlx2YmL3INgfqE02fuY2ZjPuQs5PgxV7OhOHERh Original-Received: from igel.home (ppp-46-244-163-100.dynamic.mnet-online.de [46.244.163.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 1 Jan 2021 17:38:28 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 426422C3621; Fri, 1 Jan 2021 17:38:28 +0100 (CET) X-Yow: I just heard the SEVENTIES were over!! And I was just getting in touch with my LEISURE SUIT!! In-Reply-To: (Stefan Kangas's message of "Fri, 1 Jan 2021 10:21:24 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197138 Archived-At: On Jan 01 2021, Stefan Kangas wrote: >>> --- a/src/fns.c >>> +++ b/src/fns.c >>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, >>> if (c == '=') >>> continue; >>> >>> - if (v1 < 0) >>> - return -1; Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."